-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore(deps): update all non-major dependencies #8963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Command | Status | Duration | Result |
---|---|---|---|
nx affected --targets=test:sherif,test:knip,tes... |
❌ Failed | 1m 10s | View ↗ |
nx run-many --target=build --exclude=examples/*... |
❌ Failed | 9s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-09-03 08:05:25
UTC
f5886b1
to
e17502f
Compare
49a66df
to
69ffb91
Compare
911615f
to
ef0b7d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
examples/angular/auto-refetching/package.json (1)
19-19
: Zone.js is pinned while others use caret ranges—consider normalizing semver style.If there’s no known breakage with newer patches, use a caret for consistency.
Apply if acceptable:
- "zone.js": "0.15.1" + "zone.js": "^0.15.1"examples/angular/basic-persister/package.json (1)
21-21
: Use a tilde range for zone.js to get patch updates and match other files.Pinning blocks bugfixes; tilde keeps you on 0.15.x without jumping minors (major-zero semantics).
- "zone.js": "0.15.1" + "zone.js": "~0.15.1"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml
(1 hunks).github/workflows/ci.yml
(1 hunks).github/workflows/pr.yml
(2 hunks)examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/2.6-basic/package.json
(1 hunks)examples/vue/2.7-basic/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(3 hunks)packages/angular-query-devtools-experimental/package.json
(1 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query-devtools/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- packages/query-persist-client-core/package.json
- examples/svelte/basic/package.json
- examples/react/chat/package.json
🚧 Files skipped from review as they are similar to previous changes (74)
- examples/react/suspense/package.json
- packages/vue-query/package.json
- examples/svelte/optimistic-updates/package.json
- .github/workflows/autofix.yml
- examples/angular/pagination/package.json
- examples/solid/basic/package.json
- examples/angular/basic/package.json
- examples/vue/nuxt3/package.json
- packages/svelte-query-devtools/package.json
- packages/solid-query-devtools/package.json
- examples/vue/2.6-basic/package.json
- examples/vue/basic/package.json
- packages/react-query-persist-client/package.json
- examples/react/basic-graphql-request/package.json
- examples/solid/basic-graphql-request/package.json
- packages/query-sync-storage-persister/package.json
- examples/react/default-query-function/package.json
- examples/react/eslint-legacy/package.json
- examples/react/playground/package.json
- packages/solid-query/package.json
- examples/angular/devtools-panel/package.json
- packages/react-query-next-experimental/package.json
- examples/vue/persister/package.json
- packages/svelte-query/package.json
- examples/react/basic/package.json
- integrations/react-webpack-5/package.json
- packages/solid-query-persist-client/package.json
- examples/solid/simple/package.json
- examples/svelte/ssr/package.json
- packages/query-test-utils/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/angular/rxjs/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/vue/dependent-queries/package.json
- examples/vue/simple/package.json
- examples/angular/query-options-from-a-service/package.json
- integrations/svelte-vite/package.json
- packages/eslint-plugin-query/package.json
- examples/svelte/star-wars/package.json
- packages/query-async-storage-persister/package.json
- examples/react/react-router/package.json
- examples/solid/solid-start-streaming/package.json
- packages/react-query-devtools/package.json
- examples/angular/simple/package.json
- examples/react/offline/package.json
- examples/react/simple/package.json
- examples/react/algolia/package.json
- examples/react/react-native/package.json
- packages/angular-query-devtools-experimental/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/svelte/auto-refetching/package.json
- packages/vue-query-devtools/package.json
- .github/workflows/ci.yml
- examples/solid/default-query-function/package.json
- integrations/solid-vite/package.json
- examples/react/rick-morty/package.json
- packages/svelte-query-persist-client/package.json
- integrations/angular-cli-20/package.json
- examples/svelte/simple/package.json
- examples/svelte/playground/package.json
- integrations/react-vite/package.json
- examples/angular/optimistic-updates/package.json
- integrations/vue-vite/package.json
- examples/solid/astro/package.json
- examples/vue/2.7-basic/package.json
- examples/react/shadow-dom/package.json
- packages/query-devtools/package.json
- packages/angular-query-experimental/package.json
- packages/react-query/package.json
- examples/angular/router/package.json
- examples/react/star-wars/package.json
- integrations/react-webpack-4/package.json
- .github/workflows/pr.yml
- package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (8)
packages/query-core/package.json (1)
61-64
: Approve bump to npm-run-all2 v5.0.2 Verified every package uses ^5.0.2 and allnpm-run-all
,run-s
, andrun-p
scripts remain fully compatible.examples/angular/auto-refetching/package.json (2)
22-24
: No available 20.2.x patch beyond 20.2.1 – dependencies are aligned.The latest patch for both @angular/cli and @angular/build is 20.2.1, matching @angular/compiler-cli, so no bump is necessary.
12-15
: Peer compatibility OK TypeScript 5.8.3 and @tanstack/angular-query-experimental satisfy Angular 20.2.x peer ranges.integrations/react-next-15/package.json (1)
9-9
: Temporal API usage not found—upgrade safe
Search across.js
,.jsx
,.ts
, and.tsx
files for impacted Temporal properties (.calendar
,.timeZone
,Temporal.Now.timeZone()
,getCalendar()
,getTimeZone()
,calendarId
,timeZoneId
,toTemporalInstant
) returned no matches. The breaking changes in @js-temporal/polyfill 0.5.x are unlikely to affect this codebase. Optionally, pin to~0.5.1
to guard against future 0.x breaking changes.packages/angular-query-persist-client/package.json (2)
60-64
: Verify Angular peer range and CI Node/TS compatibility
- DevDependencies correctly updated to ^20.2.3 to align with repo-wide Angular 20.x.
- peerDependencies (“@angular/common” and “@angular/core” at >=16.0.0) are unbounded above; if you want to prevent inadvertent Angular 21+ installs, constrain to
<21.0.0
.- No
engines.node
in this package.json—ensure CI runs on Node >=16 (and TS version supported by Angular 20) or add anengines
field for clarity.
67-71
: Confirm peer compatibility for Angular 20 and Node engine
@testing-library/angular@^17.4.0 is officially supported on Angular 13–19, so using it with Angular 20 may trigger peer warnings—validate tests or upgrade the testing library as needed. Also ensure Node ≥18 for @testing-library/dom@^10.4.1.examples/angular/basic-persister/package.json (2)
12-15
: Angular 20.2.x alignment verified. All example and integrationpackage.json
files use@angular/*@^20.2.x
—no mismatched minors detected.
24-26
: Align @angular/cli and @angular/build to 20.2.3; confirm TS 5.8.3 compatibility
Optional: bump both to^20.2.3
to match@angular/compiler-cli
and reduce version skew. Manually verify that your TypeScript (5.8.3) falls within Angular 20.2.x’s supported range.
ef0b7d7
to
d3963ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (3)
examples/react/basic/package.json (1)
21-22
: React 19 example still pins @types/react(‑dom) v18 — align or removeWith React 19, types are bundled; keeping v18 type packages can cause TS conflicts. Prefer removing them (or bump to ^19 if you intentionally keep them).
Apply one of the following:
Option A (preferred): remove redundant type packages
"devDependencies": { "@tanstack/eslint-plugin-query": "^5.83.1", - "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", "@vitejs/plugin-react": "^4.7.0", "typescript": "5.8.3", "vite": "^6.3.5" }Option B: bump to React 19 types
- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.0", + "@types/react-dom": "^19.0.0",examples/react/playground/package.json (1)
1-5
: Add Node engine constraint for Vite 6 compatibilityThis example lacks an engines block; add Node >=18 to avoid runtime/tooling mismatches.
{ "name": "@tanstack/query-example-react-playground", "private": true, "type": "module", + "engines": { + "node": ">=18" + }, "scripts": {packages/react-query/package.json (1)
73-74
: RTL v16 bump looks fine; ensure CI validates React 18 and 19.Aligns with React 19. Please verify the CI matrix runs tests against both React 18 and 19 to catch ecosystem edge cases with @testing-library/react v16 and react-render-stream v2. If this is already covered in workflows, ignore.
#!/bin/bash # Show where React versions are exercised in CI and list RTL/React versions per package echo "— Workflows with matrices —" fd -t f -g ".github/workflows/*.yml" rg -nC2 -e 'matrix' -e 'react-version' .github/workflows || true echo echo "— Packages using RTL and their React ranges —" fd -a package.json | while read -r f; do rtl=$(jq -r '.devDependencies["@testing-library/react"] // empty' "$f") react=$(jq -r '.devDependencies.react // .peerDependencies.react // empty' "$f") if [[ -n "$rtl" || -n "$react" ]]; then printf "%s -> rtl=%s react=%s\n" "$f" "${rtl:-∅}" "${react:-∅}" fi done | sort
🧹 Nitpick comments (1)
examples/svelte/auto-refetching/package.json (1)
21-21
: Optional: Align @sveltejs/vite-plugin-svelte with Vite 6.3.x.Your Vite is ^6.3.5; consider bumping the Svelte Vite plugin to ^6.x for full Vite 6.3+ alignment and recent fixes. Note: v6 drops Node 18 support and requires Vite ≥6.3. Gate this on Node ≥20 in CI. (github.com)
Apply if acceptable:
- "@sveltejs/vite-plugin-svelte": "^5.1.1", + "@sveltejs/vite-plugin-svelte": "^6.1.3",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml
(1 hunks).github/workflows/ci.yml
(1 hunks).github/workflows/pr.yml
(2 hunks)examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/2.6-basic/package.json
(1 hunks)examples/vue/2.7-basic/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(3 hunks)packages/angular-query-devtools-experimental/package.json
(1 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query-devtools/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- packages/query-core/package.json
- examples/react/default-query-function/package.json
- examples/vue/2.7-basic/package.json
🚧 Files skipped from review as they are similar to previous changes (74)
- integrations/react-vite/package.json
- examples/vue/nuxt3/package.json
- packages/angular-query-devtools-experimental/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/react-router/package.json
- examples/vue/basic/package.json
- packages/svelte-query/package.json
- examples/react/rick-morty/package.json
- examples/solid/basic/package.json
- packages/svelte-query-persist-client/package.json
- packages/svelte-query-devtools/package.json
- examples/solid/solid-start-streaming/package.json
- examples/angular/router/package.json
- packages/react-query-devtools/package.json
- integrations/vue-vite/package.json
- examples/react/basic-graphql-request/package.json
- examples/react/simple/package.json
- examples/svelte/playground/package.json
- examples/angular/devtools-panel/package.json
- packages/vue-query-devtools/package.json
- packages/vue-query/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- packages/react-query-persist-client/package.json
- examples/angular/basic/package.json
- examples/solid/simple/package.json
- packages/query-persist-client-core/package.json
- packages/react-query-next-experimental/package.json
- examples/react/algolia/package.json
- examples/angular/rxjs/package.json
- examples/vue/persister/package.json
- examples/react/devtools-panel/package.json
- packages/eslint-plugin-query/package.json
- .github/workflows/autofix.yml
- integrations/svelte-vite/package.json
- examples/vue/simple/package.json
- examples/angular/simple/package.json
- packages/query-test-utils/package.json
- packages/query-async-storage-persister/package.json
- packages/solid-query/package.json
- integrations/react-webpack-4/package.json
- examples/react/react-native/package.json
- examples/solid/default-query-function/package.json
- examples/react/star-wars/package.json
- examples/react/eslint-legacy/package.json
- examples/vue/2.6-basic/package.json
- examples/angular/optimistic-updates/package.json
- .github/workflows/pr.yml
- examples/svelte/star-wars/package.json
- examples/angular/basic-persister/package.json
- packages/solid-query-persist-client/package.json
- packages/solid-query-devtools/package.json
- examples/solid/basic-graphql-request/package.json
- examples/react/shadow-dom/package.json
- integrations/react-webpack-5/package.json
- examples/svelte/simple/package.json
- examples/solid/astro/package.json
- examples/svelte/optimistic-updates/package.json
- packages/query-sync-storage-persister/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/vue/dependent-queries/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- integrations/angular-cli-20/package.json
- examples/react/offline/package.json
- examples/angular/pagination/package.json
- integrations/solid-vite/package.json
- packages/angular-query-experimental/package.json
- examples/react/chat/package.json
- examples/react/suspense/package.json
- examples/svelte/ssr/package.json
- examples/angular/auto-refetching/package.json
- packages/query-devtools/package.json
- integrations/react-next-15/package.json
- examples/svelte/basic/package.json
- package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (8)
examples/react/basic/package.json (1)
23-25
: Vite 6.3 + @vitejs/plugin-react 4.7 bump: LGTMLooks good for this example; no breaking config changes expected here.
If not already enforced at the workspace level, consider adding
"engines": { "node": ">=18" }
to ensure compatibility with Vite 6 across examples.examples/react/playground/package.json (1)
17-19
: Vite/tooling bumps: LGTMUpgrade to @vitejs/plugin-react ^4.7.0 and vite ^6.3.5 looks correct for this example.
packages/angular-query-persist-client/package.json (2)
60-65
: All Angular devDependencies are consistently set to ^20.2.3 across the repo.
67-71
: Confirmed compatibility of testing libs with Angular 20.2.x. @testing-library/angular v17.4.0 and @testing-library/dom v10.4.1 are officially supported on Angular 20.x; no further changes needed.packages/react-query/package.json (1)
77-78
: Vite and @vitejs/plugin-react versions are consistent across all packages that include them; no action required.examples/svelte/auto-refetching/package.json (1)
15-16
: Verify CI workflows pin Node.js ≥20
Could not detectactions/setup-node
ornode-version
settings in.github/workflows
; ensure all CI pipelines specifynode-version: 20.x
or higher..github/workflows/ci.yml (2)
30-30
: Checkout upgrade to v4.3.0 looks good.No breaking inputs here; step behavior remains the same.
30-30
: The script is running to inspectscripts/publish.ts
for Git operations or GitHub API usage that might depend on persisted credentials. I'll update the review recommendation once we confirm whether disablingpersist-credentials
breaks the publish step. [pending]
d3963ed
to
a635125
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
♻️ Duplicate comments (4)
examples/angular/basic/package.json (1)
1-27
: Pin Node in CI and declare engines for local installsAngular 20.2.x requires a modern Node. Add engines here and set up actions/setup-node in CI to avoid mismatches. (Echoing earlier review guidance.)
Add engines to this package.json:
{ "name": "@tanstack/query-example-angular-basic", "type": "module", + "engines": { + "node": ">=20.19 || >=22.12 || >=24" + }, "scripts": {Check CI for Node setup:
#!/bin/bash set -euo pipefail # Look for setup-node usage and explicit node-version pins fd -a .github/workflows -e yml -e yaml || true echo "---- node-version fields ----" rg -n -C2 -uu -g ".github/workflows/**/*.{yml,yaml}" 'node-version:' || echo "No node-version fields found." echo "---- setup-node usage ----" rg -n -C2 -uu -g ".github/workflows/**/*.{yml,yaml}" 'uses:\s*actions/setup-node' || echo "No setup-node usage found."examples/solid/astro/package.json (1)
17-17
: Add Node engine and double-check Vercel adapter settings.
Same note as before; pin Node to avoid Vercel picking an incompatible runtime.Apply near the top-level of this package.json:
"type": "module", + "engines": { + "node": ">=18.17" + },Also confirm the Vercel project targets Astro’s output directory for this example.
examples/react/basic/package.json (1)
21-22
: Align React type packages with React 19 (or drop them).This example uses react/react-dom ^19 but still pins @types/react* to ^18, which can cause TS friction. Either bump to ^19 or remove if you rely on React 19’s built-in types.
Apply one of the following diffs:
Option A — bump types:
- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.0", + "@types/react-dom": "^19.0.0",Option B — remove types (if not needed):
- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25",examples/svelte/load-more-infinite-scroll/package.json (1)
15-16
: SvelteKit + adapter bump looks consistent across Svelte examplesThese versions align with the rest of the Svelte example packages. Nice cleanup.
🧹 Nitpick comments (2)
examples/angular/basic/package.json (1)
19-19
: Allow patch updates for zone.jsPinning to an exact 0.15.1 may miss patch fixes. Prefer a tilde to auto-receive 0.15.x patches while avoiding minor bumps.
- "zone.js": "0.15.1" + "zone.js": "~0.15.1"examples/solid/astro/package.json (1)
21-21
: Consolidatesolid-js
versions workspace-wide (optional).
We’re currently pulling both^1.6.0
and^1.9.9
in several packages (e.g.packages/solid-query
,packages/solid-query-persist-client
,packages/solid-query-devtools
). Consider adding a root-level PNPM override in your top-levelpackage.json
to locksolid-js
to a single version and avoid duplicate installs:{ "pnpm": { "overrides": { "solid-js": "1.9.9" } } }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml
(1 hunks).github/workflows/ci.yml
(1 hunks).github/workflows/pr.yml
(2 hunks)examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/2.6-basic/package.json
(1 hunks)examples/vue/2.7-basic/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(3 hunks)packages/angular-query-devtools-experimental/package.json
(1 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query-devtools/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- examples/react/shadow-dom/package.json
- examples/vue/basic/package.json
🚧 Files skipped from review as they are similar to previous changes (74)
- examples/react/suspense/package.json
- packages/query-core/package.json
- integrations/react-next-15/package.json
- examples/vue/nuxt3/package.json
- packages/vue-query/package.json
- examples/react/devtools-panel/package.json
- packages/svelte-query/package.json
- packages/angular-query-devtools-experimental/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/react/offline/package.json
- examples/vue/2.7-basic/package.json
- packages/react-query/package.json
- examples/angular/optimistic-updates/package.json
- examples/react/simple/package.json
- examples/react/eslint-legacy/package.json
- packages/svelte-query-persist-client/package.json
- integrations/vue-vite/package.json
- packages/query-persist-client-core/package.json
- examples/solid/simple/package.json
- examples/svelte/simple/package.json
- integrations/react-vite/package.json
- examples/solid/basic-graphql-request/package.json
- packages/react-query-persist-client/package.json
- examples/svelte/optimistic-updates/package.json
- examples/react/chat/package.json
- integrations/react-webpack-5/package.json
- packages/react-query-devtools/package.json
- packages/solid-query-persist-client/package.json
- packages/query-broadcast-client-experimental/package.json
- integrations/svelte-vite/package.json
- packages/query-async-storage-persister/package.json
- integrations/solid-vite/package.json
- examples/angular/pagination/package.json
- .github/workflows/pr.yml
- packages/vue-query-devtools/package.json
- examples/react/default-query-function/package.json
- examples/vue/persister/package.json
- examples/angular/simple/package.json
- examples/svelte/ssr/package.json
- packages/query-test-utils/package.json
- examples/vue/dependent-queries/package.json
- examples/solid/basic/package.json
- examples/react/rick-morty/package.json
- examples/vue/simple/package.json
- examples/angular/basic-persister/package.json
- examples/react/react-native/package.json
- examples/angular/rxjs/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- .github/workflows/ci.yml
- packages/svelte-query-devtools/package.json
- examples/solid/solid-start-streaming/package.json
- packages/angular-query-experimental/package.json
- .github/workflows/autofix.yml
- examples/svelte/basic/package.json
- packages/react-query-next-experimental/package.json
- examples/angular/router/package.json
- examples/react/playground/package.json
- packages/solid-query/package.json
- examples/react/react-router/package.json
- examples/react/algolia/package.json
- examples/solid/default-query-function/package.json
- examples/angular/devtools-panel/package.json
- packages/query-sync-storage-persister/package.json
- examples/svelte/playground/package.json
- examples/vue/2.6-basic/package.json
- examples/angular/auto-refetching/package.json
- integrations/react-webpack-4/package.json
- examples/react/star-wars/package.json
- examples/svelte/auto-refetching/package.json
- packages/eslint-plugin-query/package.json
- integrations/angular-cli-20/package.json
- examples/svelte/star-wars/package.json
- packages/angular-query-persist-client/package.json
- package.json
🔇 Additional comments (13)
examples/angular/basic/package.json (2)
12-15
: Angular core bumps look goodVersions are consistent across core packages and align with the TS/RxJS used in this example.
22-24
: No action needed — packages already pinned to the latest 20.2.x releases.Likely an incorrect or invalid review comment.
packages/solid-query-devtools/package.json (1)
68-72
: Dev-deps bumps LGTM; verify binaries and peer deps
- Confirm that npm-run-all2 exposes the
npm-run-all
CLI so existingnpm-run-all
scripts continue working.- Check that [email protected]’s peerDependencies include Vite ^6.3.5 to match the repo’s Vite version.
packages/query-devtools/package.json (3)
80-80
: Resolved: workspace Vite versions satisfy [email protected] peerDependencies
Workspace Vite versions (^4.5.14 and ^6.3.5) both fall within the required range (^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0). No changes needed.
67-69
: Peer dependency ranges are compatible with solid-js ^1.9.9
@kobalte/[email protected] (solid-js ^1.8.15), @solid-primitives/[email protected] and @solid-primitives/[email protected] (both solid-js ^1.6.12) all accept solid-js 1.9.9, so no changes are needed.
75-77
: Verify npm-run-all2 binary and smoke-test solid-transition-group upgrade
- [email protected] exports the
npm-run-all
CLI, so existing scripts invokingnpm-run-all
should continue working.- Devtools.tsx imports
TransitionGroup
fromsolid-transition-group
; exercise the DevTools UI locally to ensure no breaking API changes in the 0.3.0 release.- On a clean checkout, run
pnpm install && pnpm build
to confirm the build still succeeds and no binaries (e.g.tsup
,nx
) are missing.examples/solid/astro/package.json (1)
22-22
: LGTM on tailwindcss bump.
No breaking changes expected for this example.examples/react/basic/package.json (1)
23-25
: Vite + plugin-react bumps look good.Non-major upgrades; no API changes expected for this example.
examples/react/basic-graphql-request/package.json (2)
13-14
: GraphQL deps bump looks safe.Minor/patch updates for graphql and graphql-request; typical non-breaking surface for examples.
19-20
: Ensure CI/dev Node version ≥18 for Vite 6
I didn’t find anyuses: actions/setup-node
withnode-version
in.github/workflows
; please verify your workflows and local dev configs specify Node 18+ to satisfy Vite 6.examples/svelte/load-more-infinite-scroll/package.json (3)
15-22
: Confirm TypeScript 5.8.3 exists and matches workspace root — npm registry includes version 5.8.3 and the root package.json likewise pins 5.8.3; no changes needed.
18-19
: Compatibility confirmed:svelte-check@^4.3.1
supports Svelte 5.x (including 5.38.6) per the official release notes and peer-dependency listing.
17-21
: No action needed: @sveltejs/[email protected] supports Vite 6 & Svelte 5
Vite 6 support was added in the 5.0.0 release (#1026) and v5.1.0 requires Vite 6.2 and Svelte 5.26, so v5.1.1 is fully compatible with Vite ^6.3.x and Svelte ^5.38.x. (newreleases.io)
"@vitejs/plugin-react": "^4.7.0", | ||
"typescript": "5.8.3", | ||
"vite": "^6.2.4" | ||
"vite": "^6.3.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Confirm Node engine compatibility in CI for Vite 6.
Vite 6 requires modern Node (>=18). Ensure workflows and local dev use a compatible version.
🏁 Script executed:
#!/bin/bash
# Verify Node versions configured in GitHub Actions and .nvmrc/.tool-versions
fd -a .github/workflows -e yml -e yaml | xargs rg -nC2 'setup-node@|node-version'
fd -a -p -H -I -t f '.nvmrc' '.tool-versions' | xargs -I{} sh -c 'echo "==> {}"; cat "{}"'
Length of output: 1471
🏁 Script executed:
#!/bin/bash
# Properly list and search through CI workflows for Node setup
fd . .github/workflows -t f -e yml -e yaml | xargs -I{} sh -c 'echo "==> {}"; rg -n "\bsetup-node\b|\bnode-version\b" "{}" || true'
Length of output: 261
🏁 Script executed:
#!/bin/bash
# Check GitHub Actions for Node version setup
fd -t f -e yml -e yaml .github/workflows | xargs -I{} sh -c '
echo "==> {}"
rg -n "actions/setup-node@|node-version:" "{}" || echo " No setup-node or node-version found"
'
# Check local version files
for file in .nvmrc .node-version .tool-versions; do
if [ -f "$file" ]; then
echo "==> $file"
if [ "$file" = ".tool-versions" ]; then
grep -E "nodejs? " "$file" || echo " No node entry in $file"
else
cat "$file"
fi
else
echo "==> $file not found"
fi
done
Length of output: 996
🏁 Script executed:
#!/bin/bash
# Accurately search CI workflows for Node version configuration
find .github/workflows -type f \( -name "*.yml" -o -name "*.yaml" \) -print | while read file; do
echo "==> $file"
grep -nE 'actions/setup-node@|node-version:' "$file" || echo " no node setup found"
done
Length of output: 937
Specify Node version in CI workflows
CI configs under .github/workflows/*.yml
don’t install or pin a Node version. Add actions/setup-node@v3
with node-version: ">=18"
(e.g. matching your .nvmrc
’s 24.4.1
) to guarantee Vite 6 compatibility.
🤖 Prompt for AI Agents
In examples/react/basic/package.json around lines 23 to 25, the project uses
Vite 6 but CI workflows under .github/workflows/*.yml do not pin a Node version;
update those workflow files to add the actions/setup-node@v3 step and set
node-version: ">=18" (or explicitly match .nvmrc like "24.4.1") before
installing dependencies so the CI runs with a compatible Node release for Vite
6.
@@ -12,14 +12,14 @@ | |||
"dependencies": { | |||
"@astrojs/check": "^0.9.4", | |||
"@astrojs/node": "^9.1.3", | |||
"@astrojs/solid-js": "^5.0.7", | |||
"@astrojs/solid-js": "^5.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
@astrojs/solid-js bump looks fine; verify peer-deps with solid-js.
Run a quick peer check to prevent subtle install-time warnings.
🏁 Script executed:
#!/bin/bash
# Verify peer requirements for the example
pnpm -C examples/solid/astro explain peer-requirements
Length of output: 144
🏁 Script executed:
#!/bin/bash
# Fetch peerDependencies for @astrojs/[email protected] from npm registry
pnpm info @astrojs/[email protected] peerDependencies
Length of output: 106
🏁 Script executed:
#!/bin/bash
# Check for solid-js and solid-devtools in the example's package.json
grep -E '"solid-js"|"solid-devtools"' -n examples/solid/astro/package.json || echo "No matches found"
Length of output: 105
Add missing ‘solid-devtools’ peer dependency
@astrojs/[email protected] peers “solid-js”@^1.8.5 (satisfied by ^1.9.9) and “solid-devtools”@^0.30.1; add “solid-devtools”: “^0.30.1” to examples/solid/astro/package.json to avoid install warnings.
🤖 Prompt for AI Agents
In examples/solid/astro/package.json around line 15, the dependency list
includes "@astrojs/solid-js": "^5.1.0" but omits the peer dependency
"solid-devtools" required by that package; add "solid-devtools": "^0.30.1" to
the dependencies (or devDependencies) section of package.json so npm/yarn
install doesn't emit peer dependency warnings, and then run an install to verify
no peer warnings remain.
"typescript": "5.8.3", | ||
"vite": "^6.2.4" | ||
"vite": "^6.3.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Confirm Node.js engine in CI matches Vite 6 requirement
Vite 6 requires a modern Node LTS. Please confirm the repo’s engines field and CI matrix use a compatible Node version.
Optionally pin an engines field in this example:
"private": true,
"type": "module",
+ "engines": {
+ "node": ">=18.18.0 || >=20"
+ },
🏁 Script executed:
#!/bin/bash
# Report engines.node from all package.json files and Node versions in GitHub Actions
fd -a package.json | xargs -I{} jq -r '.name + " engines.node=" + ( .engines.node // "N/A")' {} | sed 's/null/N\/A/'
rg -nC2 'actions/setup-node@|node-version' -g '.github/workflows/**/*.yml'
Length of output: 5332
🏁 Script executed:
#!/bin/bash
# Check CI workflows for Node version setup
echo "=== .github/workflows contents ==="
if [ -d ".github/workflows" ]; then
ls .github/workflows
echo
echo "=== setup-node@ usage in workflows ==="
rg -n -C2 'setup-node@' .github/workflows
echo
echo "=== node-version entries in workflows ==="
rg -n 'node-version:' .github/workflows
else
echo "No .github/workflows directory found."
fi
# Inspect engines field in root and example package.json
echo
echo "=== Root package.json engines field ==="
jq -r '.engines // "N/A"' package.json
echo
echo "=== examples/svelte/load-more-infinite-scroll/package.json engines field ==="
jq -r '.engines // "N/A"' examples/svelte/load-more-infinite-scroll/package.json || echo "File not found"
Length of output: 848
Add missing Node.js engine field and pin CI Node version
- No
engines.node
is declared inexamples/svelte/load-more-infinite-scroll/package.json
(or at the repo root), and Vite 6 requires Node ≥ 18.18.0 (or ≥ 20). - Your GitHub Actions workflows (e.g.
.github/workflows/ci.yml
) don’t useactions/setup-node
or specifynode-version
, so CI may run on an unsupported Node.
Please add an engines.node
entry (">=18.18.0 || >=20"
) in the example’s package.json
and update your CI jobs to use actions/setup-node@v3
with a compatible node-version
matrix.
🤖 Prompt for AI Agents
In examples/svelte/load-more-infinite-scroll/package.json around line 21, add an
engines.node field to declare supported Node versions (use ">=18.18.0 || >=20")
so consumers and tools know Vite 6’s requirement; then update CI workflows (e.g.
.github/workflows/ci.yml) to include actions/setup-node@v3 and a node-version
matrix that matches those versions so CI runs on a supported Node runtime.
a635125
to
5f18610
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
63-64
: Bump React versions in examples/integrations to ^19.0.0
Several integrations and example package.json files still pin React 18 (e.g. integrations/react-next-14/package.json lines 11–12; all examples under examples/react/*). Update each to use"react": "^19.0.0"
and"react-dom": "^19.0.0"
to avoid installing duplicate React majors.
♻️ Duplicate comments (2)
packages/react-query/package.json (1)
73-79
: Testing libs/tooling bumps OK; ensure CI tests React 18 and 19.@testing-library/react 16.x supports 18/19. Please validate against both in CI to catch edge cases.
Proposed matrix snippet for .github/workflows/ci.yml:
strategy: matrix: react-version: [18, 19] steps: - uses: actions/setup-node@v4 with: node-version: '20' - name: Install deps run: pnpm i --filter "@tanstack/react-query..." - name: Test run: | pnpm -w -r exec -- pnpm add -D react@${{ matrix.react-version }} react-dom@${{ matrix.react-version }} pnpm -w -r run test:libpackage.json (1)
8-8
: Ensure CI uses pnpm 10.15.1 (corepack or setup) to avoid lockfile churnpackageManager bumped to [email protected]. Make sure workflows install/activate the same pnpm version (either via corepack or pnpm/action-setup) before install steps; otherwise CI may resolve with a different pnpm and rewrite the lockfile.
Run to check workflows:
#!/bin/bash # Search all workflows for pnpm/corepack setup and version pinning fd -H -t f -g ".github/workflows/*.{yml,yaml}" \ -x rg -nC2 -e 'corepack|setup-node|pnpm/action-setup|setup-pnpm|pnpm-version|pnpm@' # Quick grep for explicit 10.15.1 pin fd -H -t f -g ".github/workflows/*.{yml,yaml}" -x rg -n "10\.15\.1"Example step (corepack approach):
- uses: actions/setup-node@v4 with: node-version: 'lts/*' cache: 'pnpm' - run: corepack enable && corepack prepare [email protected] --activate
🧹 Nitpick comments (2)
package.json (2)
41-45
: ESLint 9 upgrade: verify plugin compatibility and the RC tageslint is ^9.34.0 while eslint-plugin-react-hooks is an RC (6.0.0-rc1). Confirm plugin compatibility across the monorepo and consider pinning the RC without a caret to avoid unexpected bumps, or move to a stable tag once available.
Also applies to: 53-56
62-62
: Add publint to CI so the new tool actually runspublint is listed but not wired into scripts included by nx in test:ci. Consider a script like test:publint and include it in nx affected/test:ci.
"scripts": { + "test:publint": "publint", "test:ci": "nx run-many --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build", }, "nx": { "includedScripts": [ "test:sherif", - "test:knip" + "test:knip", + "test:publint" ] },Also applies to: 65-67
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml
(1 hunks).github/workflows/ci.yml
(1 hunks).github/workflows/pr.yml
(2 hunks)examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/2.6-basic/package.json
(1 hunks)examples/vue/2.7-basic/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(3 hunks)packages/angular-query-devtools-experimental/package.json
(1 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query-devtools/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- examples/react/offline/package.json
- packages/svelte-query-devtools/package.json
- examples/solid/simple/package.json
- packages/query-devtools/package.json
🚧 Files skipped from review as they are similar to previous changes (73)
- packages/react-query-persist-client/package.json
- examples/react/rick-morty/package.json
- packages/query-async-storage-persister/package.json
- integrations/react-vite/package.json
- packages/query-persist-client-core/package.json
- examples/react/suspense/package.json
- .github/workflows/pr.yml
- packages/svelte-query-persist-client/package.json
- packages/query-core/package.json
- examples/react/shadow-dom/package.json
- packages/angular-query-persist-client/package.json
- examples/vue/2.6-basic/package.json
- packages/angular-query-devtools-experimental/package.json
- examples/vue/simple/package.json
- integrations/react-webpack-5/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- packages/vue-query/package.json
- examples/react/devtools-panel/package.json
- packages/solid-query-persist-client/package.json
- examples/solid/default-query-function/package.json
- examples/angular/basic-persister/package.json
- packages/vue-query-devtools/package.json
- examples/vue/2.7-basic/package.json
- integrations/svelte-vite/package.json
- examples/react/basic-graphql-request/package.json
- integrations/solid-vite/package.json
- examples/angular/basic/package.json
- packages/svelte-query/package.json
- integrations/react-next-15/package.json
- examples/svelte/basic/package.json
- integrations/vue-vite/package.json
- packages/query-sync-storage-persister/package.json
- packages/react-query-devtools/package.json
- examples/solid/solid-start-streaming/package.json
- examples/angular/auto-refetching/package.json
- examples/vue/basic/package.json
- .github/workflows/autofix.yml
- examples/angular/rxjs/package.json
- examples/react/eslint-legacy/package.json
- examples/react/simple/package.json
- examples/react/algolia/package.json
- examples/solid/basic/package.json
- examples/svelte/playground/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/svelte/ssr/package.json
- examples/angular/simple/package.json
- packages/solid-query-devtools/package.json
- examples/react/basic/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/svelte/simple/package.json
- examples/react/react-router/package.json
- packages/query-test-utils/package.json
- examples/react/star-wars/package.json
- examples/svelte/optimistic-updates/package.json
- examples/angular/optimistic-updates/package.json
- examples/svelte/star-wars/package.json
- examples/solid/astro/package.json
- packages/react-query-next-experimental/package.json
- examples/solid/basic-graphql-request/package.json
- examples/angular/pagination/package.json
- examples/angular/devtools-panel/package.json
- integrations/react-webpack-4/package.json
- examples/angular/query-options-from-a-service/package.json
- packages/angular-query-experimental/package.json
- examples/vue/nuxt3/package.json
- examples/svelte/auto-refetching/package.json
- examples/angular/router/package.json
- examples/react/react-native/package.json
- .github/workflows/ci.yml
- integrations/angular-cli-20/package.json
- examples/react/playground/package.json
- examples/vue/persister/package.json
- packages/eslint-plugin-query/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (5)
examples/react/default-query-function/package.json (1)
17-19
: CI workflows lack Node version pinning — confirm Node ≥18
We didn’t find anyactions/setup-node
ornode-version
entries in your GitHub Actions workflows. Ensure your CI is running Node 18 or newer (e.g. viaactions/setup-node
) to meet Vite 6’s requirements.examples/vue/dependent-queries/package.json (1)
15-17
: Vue Vite stack bump consistent and safe.@vitejs/plugin-vue ^5.2.4 + vite ^6.3.5 matches the repo-wide toolchain. No action needed.
packages/solid-query/package.json (1)
74-78
: Dev deps bumps are fine and non-breaking.npm-run-all2, solid-js (dev), and vite-plugin-solid updates are minor/patch and compatible with existing scripts.
package.json (2)
49-50
: Coverage provider alignment verifiedAll Vite configs explicitly set
provider: 'istanbul'
, so no alignment changes are needed. Consider migrating tocoverage-v8
if Istanbul isn’t required.
68-76
: TypeScript matrix: confirm CI covers default TS 5.8.3 and aliases 5.0–5.7
Ensure your GitHub Actions strategy matrix invokes thetest:types
script against eachtypescript50
–typescript57
alias plus the default 5.8.3, and that any package targeting an older TS version explicitly references its corresponding alias to prevent TS 5.8 features from leaking.
"@tailwindcss/vite": "^4.1.12", | ||
"@vitejs/plugin-react": "^4.7.0", | ||
"tailwindcss": "^4.1.12", | ||
"typescript": "5.8.3", | ||
"vite": "^6.2.4" | ||
"vite": "^6.3.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Tailwind 4.1 + Vite/plugin-react bumps LGTM; ensure Tailwind v4 config is present.
Tailwind v4 consolidates config and relies on the PostCSS plugin differently. Quick sanity: confirm the example imports Tailwind and (if used) has a tailwind.config.{ts,js}.
Run:
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
echo "Tailwind config files:"
fd -a -g "tailwind.config.*" examples/react/chat || true
echo "CSS imports of Tailwind:"
rg -n '@import\s+"tailwindcss"|@config\s' examples/react/chat -g '**/*.{css,pcss,scss}' || true
echo "Build the example (dry check of scripts):"
jq -r '.scripts' examples/react/chat/package.json
Length of output: 498
Add missing Tailwind v4 config and CSS directives
The examples/react/chat
example has no tailwind.config.{js,ts}
at its root and the CSS entry doesn’t include the required @tailwind base
, @tailwind components
, and @tailwind utilities
directives. Add a config file and import a CSS file with those directives in your main entry so Tailwind v4 functions correctly.
🤖 Prompt for AI Agents
In examples/react/chat/package.json around lines 17 to 21, the project is
missing a Tailwind v4 configuration and the CSS entry lacks the required
@tailwind base, @tailwind components, and @tailwind utilities directives; add a
tailwind.config.js (or .ts) at the example root with appropriate content paths
(e.g., ./index.html and ./src/**/*.{js,jsx,ts,tsx}) and any theme/plugins
needed, create a CSS file (e.g., src/index.css) containing the three directives
(@tailwind base; @tailwind components; @tailwind utilities) and then import that
CSS from the main entry (e.g., src/main.jsx or src/main.tsx) so Tailwind v4 is
initialized for the example.
"@cspell/eslint-plugin": "^8.19.4", | ||
"@eslint-react/eslint-plugin": "^1.52.9", | ||
"@tanstack/config": "^0.20.1", | ||
"@testing-library/jest-dom": "^6.8.0", | ||
"@types/node": "^22.15.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Node version consistency for tooling
@types/node ^22.15.3, nx 21.4.1, and TS 5.8.3 may assume a newer Node. Ensure CI/setup-node uses a Node LTS that’s compatible with all tools (and with frameworks in examples).
Also applies to: 58-58, 68-68
🏁 Script executed:
#!/bin/bash
# Verify Node versions used in workflows
fd -H -t f -g ".github/workflows/*.{yml,yaml}" -x rg -nC2 'setup-node|node-version|matrix.*node'
Length of output: 98
🏁 Script executed:
#!/bin/bash
if [ -d .github/workflows ]; then
echo ".github/workflows directory found:"
find .github/workflows -type f \( -name "*.yml" -o -name "*.yaml" \)
echo "Searching for Node configuration in workflow files:"
grep -R -nE 'setup-node|node-version|matrix.*node' .github/workflows
else
echo ".github/workflows directory not found"
fi
Length of output: 476
Pin Node version in CI/PR workflows
The workflows under .github/workflows (ci.yml, pr.yml, autofix.yml, labeler.yml) don’t invoke actions/setup-node or pin a Node version. Explicitly add actions/setup-node@v3
with node-version: '22.x'
(or your chosen LTS) in each workflow to guarantee compatibility with @types/node@^22.15.3
, nx 21.4.1, and TS 5.8.3.
🤖 Prompt for AI Agents
In package.json around line 46, CI workflows under .github/workflows (ci.yml,
pr.yml, autofix.yml, labeler.yml) do not pin a Node version which can cause
mismatches with @types/node@^22.15.3; update each workflow to add the
actions/setup-node@v3 step and set node-version: '22.x' (or your chosen LTS)
before running install/build/test steps so the runner uses a consistent Node
version compatible with nx 21.4.1 and TS 5.8.3.
ebbb7bd
to
8449b44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
.github/workflows/autofix.yml (1)
21-21
: Upgrade to actions/checkout v4.3.0 looks fine; consider pinning and permissions.
- Optional: Pin checkout to the v4.3.0 commit SHA (like you did for autofix-ci/action) for supply-chain hardening.
- If the autofix step must push commits with GITHUB_TOKEN, set
permissions: contents: write
; otherwiseread
is fine when relying on the Autofix.ci App.examples/angular/pagination/package.json (2)
19-19
: zone.js 0.15.1 is fine; consider future zoneless example.No action needed now. If you later migrate this example to zoneless change detection, you can drop the zone.js dependency. (npmjs.com)
22-24
: Dev tooling versions are aligned; optional patch-sync.CLI/build are ^20.2.1 and compiler-cli is ^20.2.3. Functionally fine; if you prefer strict patch consistency across Angular toolchain, bump build/cli to ^20.2.3 as well. Also note v20.2 adds TS 5.9 support if you plan to move off 5.8 later. (blog.ninja-squad.com, angular.dev)
integrations/vue-vite/package.json (2)
5-7
: Add dev/preview scripts for local DX (optional).Handy defaults help triage upgrades quickly.
"scripts": { - "build": "vite build" + "build": "vite build", + "dev": "vite", + "preview": "vite preview" },
13-16
: plugin-vue ↔ Vite compatibility & version consistency verified
- @vitejs/[email protected] peerDependencies include “vite”: “^5.0.0 || ^6.0.0”, so vite@^6.3.5 is satisfied.
- plugin-vue is pinned to ^5.2.4 everywhere; vite is ^6.3.5 in all integrations/examples (Vue 2 demos intentionally use ^4.5.14).
- [email protected]’s engines.node is “^18.0.0 || ^20.0.0 || >=22.0.0”; only examples/solid/solid-start-streaming/package.json enforces node>=18. Recommend adding an engines.node >=18 constraint in the root package.json or CI to enforce the Node version repo-wide.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml
(1 hunks).github/workflows/ci.yml
(1 hunks).github/workflows/pr.yml
(2 hunks)examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/2.6-basic/package.json
(1 hunks)examples/vue/2.7-basic/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(3 hunks)packages/angular-query-devtools-experimental/package.json
(1 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query-devtools/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- packages/query-sync-storage-persister/package.json
- examples/react/default-query-function/package.json
- examples/svelte/ssr/package.json
- packages/vue-query-devtools/package.json
🚧 Files skipped from review as they are similar to previous changes (73)
- examples/react/playground/package.json
- packages/query-broadcast-client-experimental/package.json
- packages/query-persist-client-core/package.json
- examples/react/devtools-panel/package.json
- examples/vue/simple/package.json
- examples/solid/astro/package.json
- examples/react/eslint-legacy/package.json
- examples/svelte/star-wars/package.json
- packages/angular-query-experimental/package.json
- examples/react/algolia/package.json
- packages/angular-query-devtools-experimental/package.json
- integrations/react-next-15/package.json
- examples/solid/basic/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/react/suspense/package.json
- integrations/react-vite/package.json
- examples/react/react-native/package.json
- examples/react/simple/package.json
- examples/svelte/simple/package.json
- integrations/react-webpack-5/package.json
- examples/solid/solid-start-streaming/package.json
- examples/svelte/optimistic-updates/package.json
- packages/react-query-devtools/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/solid-query-devtools/package.json
- packages/eslint-plugin-query/package.json
- examples/react/basic-graphql-request/package.json
- examples/vue/basic/package.json
- examples/angular/simple/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/angular/optimistic-updates/package.json
- packages/solid-query/package.json
- packages/react-query/package.json
- packages/react-query-persist-client/package.json
- examples/vue/2.6-basic/package.json
- packages/query-devtools/package.json
- .github/workflows/ci.yml
- examples/react/star-wars/package.json
- packages/svelte-query/package.json
- examples/react/basic/package.json
- examples/react/react-router/package.json
- packages/svelte-query-devtools/package.json
- packages/angular-query-persist-client/package.json
- examples/react/offline/package.json
- examples/react/chat/package.json
- examples/angular/router/package.json
- examples/angular/devtools-panel/package.json
- examples/vue/nuxt3/package.json
- examples/angular/basic/package.json
- examples/angular/rxjs/package.json
- packages/svelte-query-persist-client/package.json
- packages/query-core/package.json
- .github/workflows/pr.yml
- examples/vue/dependent-queries/package.json
- integrations/svelte-vite/package.json
- integrations/angular-cli-20/package.json
- examples/solid/basic-graphql-request/package.json
- examples/react/rick-morty/package.json
- examples/svelte/playground/package.json
- examples/solid/simple/package.json
- integrations/solid-vite/package.json
- examples/svelte/basic/package.json
- examples/solid/default-query-function/package.json
- examples/vue/persister/package.json
- examples/svelte/auto-refetching/package.json
- integrations/react-webpack-4/package.json
- packages/solid-query-persist-client/package.json
- examples/angular/auto-refetching/package.json
- packages/query-test-utils/package.json
- package.json
- packages/vue-query/package.json
- examples/angular/basic-persister/package.json
- packages/query-async-storage-persister/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (6)
examples/vue/2.7-basic/package.json (1)
17-17
: Vite patch bump to ^4.5.14 looks good for Vue 2 + vite-plugin-vue2.Patch-only; low risk. Keep this example on Vite 4 (Vue 2 plugin compatibility), while newer examples can use Vite 6.
examples/angular/pagination/package.json (1)
12-15
: Angular 20.2.x bump looks good; TS/RxJS compatibility OK.TypeScript 5.8.3 and RxJS ^7.8.2 are within Angular v20’s supported ranges. Ensure CI uses Node.js >= 20.19 (or 22.12/24.x) to match Angular 20 requirements. (angular.dev)
examples/react/shadow-dom/package.json (1)
19-19
: Dev dep bumps LGTM; Node and peer constraints verified.
Node v24.3.0 satisfies [email protected] engines (^18.0.0 || ^20.0.0 || >=22.0.0), and @vitejs/[email protected] accepts vite ^6.x. There are no React peerDependencies, so React 19 compatibility is unaffected.packages/react-query-next-experimental/package.json (3)
58-65
: LGTM on minor/patch bumps in devDependencies.Non-breaking and consistent with the PR’s scope.
61-61
: Retain @vitejs/plugin-react and verify Vite version
packages/react-query-next-experimental/vite.config.ts imports and uses this plugin, so don’t remove or hoist it. Ensure that either this package or the root workspace has “vite” declared and that its version satisfies the plugin-react peer range (^6.0.0 || ^7.0.0).
63-63
: Verifynpm-run-all
binary fromnpm-run-all2
Thetest:types
script inpackages/react-query-next-experimental/package.json
invokesnpm-run-all
. Ensure that installingnpm-run-all2
exposes thenpm-run-all
(and relatedrun-p
/run-s
) binaries in that package (e.g. runpnpm exec which npm-run-all
insidepackages/react-query-next-experimental
).
8449b44
to
fd040ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (3)
examples/solid/solid-start-streaming/package.json (1)
5-10
: Re-run the “version/build” smoke for vinxi after these bumps.Previous breakage in
vinxi version
was addressed; please reconfirm no regressions and that SSR streaming still works, and check for peer-dep warnings.#!/bin/bash set -euo pipefail # Install at workspace root to ensure consistent lockfile pnpm install --frozen-lockfile # Quick peer-deps sanity pnpm -C examples/solid/solid-start-streaming ls --depth 1 | sed -n '1,120p' # Verify vinxi CLI and build pnpm -C examples/solid/solid-start-streaming run version pnpm -C examples/solid/solid-start-streaming run buildexamples/react/suspense/package.json (1)
19-21
: LGTM on Vite/tooling bumps; ensure Node ≥ 18 is enforced.Vite 6 + @vitejs/plugin-react 4.x expect Node 18+. Add an engines constraint here (or confirm it’s inherited at the workspace root).
Apply this diff to add an engines field:
{ "name": "@tanstack/query-example-react-suspense", "private": true, "type": "module", + "engines": { + "node": ">=18" + }, "scripts": { "dev": "vite", "build": "vite build", "preview": "vite preview" },Run this to verify engines declarations across the repo and any Node version files:
#!/bin/bash set -euo pipefail echo "Packages declaring engines.node:" fd -a package.json -t f -E node_modules \ | xargs -I{} sh -c 'jq -er '\''if .engines and .engines.node then input_filename + " => " + .engines.node else empty end'\'' "{}"' || true echo -e "\nNode version files (if any):" fd -a '.nvmrc' -t f -E node_modules || true fd -a '.node-version' -t f -E node_modules || true fd -a '.tool-versions' -t f -E node_modules || trueexamples/react/react-native/package.json (1)
19-29
: Expo SDK 52 + React Native 0.81.x are incompatible; align RN to 0.76/0.77 or upgrade Expo to SDK 54.Expo SDK 52 supports RN 0.76 (default) and 0.77 (opt‑in). RN 0.81 belongs to SDK 54 (currently in beta as of Aug 19, 2025). Mixing SDK 52 with RN 0.81 will break builds and Dev Client. Also note SDK 52 maps to react-native-web 0.19.x. (expo.dev, docs.expo.dev)
Apply one of the following:
- Option A (stay on Expo 52): downgrade RN to 0.77.x and then run “npx expo install --fix” to sync reanimated, gesture-handler, screens, safe-area-context, and RN Web to the recommended versions.
- "react-native": "^0.81.1", + "react-native": "~0.77.1",
- Option B (keep RN 0.81.x): upgrade Expo to SDK 54 (RN 0.81). Then run “npx expo install --fix” to align all Expo-managed packages. (expo.dev)
Run to auto-check for this mismatch:
#!/bin/bash set -euo pipefail pkg="examples/react/react-native/package.json" expo_ver=$(jq -r '.dependencies.expo // .devDependencies.expo // empty' "$pkg") rn_ver=$(jq -r '.dependencies["react-native"] // empty' "$pkg") echo "expo: $expo_ver, react-native: $rn_ver" # Flag Expo 52 with RN >=0.80 as incompatible if [[ "$expo_ver" =~ ^\^?52\. ]] && [[ "$rn_ver" =~ ^[\^~]?0\.(8[0-9]|9[0-9])\. ]]; then echo "Incompatible: Expo SDK 52 does not support React Native $rn_ver" >&2 exit 1 fi echo "No obvious Expo/RN version skew detected."I can push a commit for Option A and run through expo-doctor notes if you want.
🧹 Nitpick comments (6)
examples/angular/pagination/package.json (2)
12-15
: Angular 20.2.x bumps look consistent; zone.js is pinned.
- Framework libs align on ^20.2.3 — good.
- Consider loosening zone.js from an exact pin to ~0.15.1 to pick patch fixes without unexpected minors.
Apply:
- "zone.js": "0.15.1" + "zone.js": "~0.15.1"Also applies to: 19-19
22-24
: Align CLI/build patch versions with framework for fewer toolchain mismatches.Optional: bump @angular/build and @angular/cli to ^20.2.3 to match compiler(-cli) and framework.
- "@angular/build": "^20.2.1", - "@angular/cli": "^20.2.1", + "@angular/build": "^20.2.3", + "@angular/cli": "^20.2.3",examples/angular/simple/package.json (2)
12-15
: Consistent Angular bumps; consider unpinning zone.js to patch range.Same rationale as other examples: prefer ~0.15.1 to receive patch fixes.
- "zone.js": "0.15.1" + "zone.js": "~0.15.1"Also applies to: 19-19
22-24
: Optional: sync tooling patch to 20.2.3.Keeps CLI/build in lockstep with framework packages.
- "@angular/build": "^20.2.1", - "@angular/cli": "^20.2.1", + "@angular/build": "^20.2.3", + "@angular/cli": "^20.2.3",examples/angular/devtools-panel/package.json (2)
12-16
: Angular core/router updates LGTM; consider ~ for zone.js.
- Core and router at ^20.2.3 are consistent.
- Suggest ~0.15.1 for zone.js to get patch updates automatically.
- "zone.js": "0.15.1" + "zone.js": "~0.15.1"Also applies to: 21-21
24-26
: Optional: align @angular/build and @angular/cli to ^20.2.3.Reduces the risk of minor patch skew across tooling.
- "@angular/build": "^20.2.1", - "@angular/cli": "^20.2.1", + "@angular/build": "^20.2.3", + "@angular/cli": "^20.2.3",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml
(1 hunks).github/workflows/ci.yml
(1 hunks).github/workflows/pr.yml
(2 hunks)examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/2.6-basic/package.json
(1 hunks)examples/vue/2.7-basic/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(3 hunks)packages/angular-query-devtools-experimental/package.json
(1 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query-devtools/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (77)
- examples/solid/basic/package.json
- examples/solid/astro/package.json
- examples/react/eslint-legacy/package.json
- packages/svelte-query/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/react/devtools-panel/package.json
- packages/angular-query-devtools-experimental/package.json
- packages/svelte-query-devtools/package.json
- integrations/solid-vite/package.json
- packages/svelte-query-persist-client/package.json
- examples/solid/basic-graphql-request/package.json
- examples/vue/basic/package.json
- examples/vue/nuxt3/package.json
- packages/query-persist-client-core/package.json
- examples/angular/basic-persister/package.json
- examples/react/algolia/package.json
- integrations/react-vite/package.json
- packages/vue-query-devtools/package.json
- examples/react/offline/package.json
- .github/workflows/ci.yml
- packages/eslint-plugin-query/package.json
- packages/solid-query-devtools/package.json
- integrations/svelte-vite/package.json
- examples/react/simple/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/solid/default-query-function/package.json
- .github/workflows/pr.yml
- packages/vue-query/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/svelte/playground/package.json
- examples/vue/simple/package.json
- examples/svelte/basic/package.json
- examples/react/basic/package.json
- examples/react/basic-graphql-request/package.json
- examples/solid/simple/package.json
- packages/query-core/package.json
- examples/react/playground/package.json
- examples/angular/optimistic-updates/package.json
- packages/query-test-utils/package.json
- packages/query-async-storage-persister/package.json
- integrations/react-next-15/package.json
- packages/react-query-devtools/package.json
- examples/angular/basic/package.json
- examples/vue/dependent-queries/package.json
- integrations/react-webpack-4/package.json
- examples/react/react-router/package.json
- packages/query-sync-storage-persister/package.json
- integrations/react-webpack-5/package.json
- packages/angular-query-persist-client/package.json
- examples/svelte/optimistic-updates/package.json
- examples/svelte/auto-refetching/package.json
- examples/react/star-wars/package.json
- integrations/vue-vite/package.json
- examples/angular/rxjs/package.json
- packages/react-query/package.json
- examples/vue/2.6-basic/package.json
- packages/react-query-persist-client/package.json
- examples/vue/2.7-basic/package.json
- packages/react-query-next-experimental/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/svelte/star-wars/package.json
- examples/svelte/ssr/package.json
- examples/react/rick-morty/package.json
- examples/react/chat/package.json
- packages/query-devtools/package.json
- examples/svelte/simple/package.json
- packages/angular-query-experimental/package.json
- examples/angular/auto-refetching/package.json
- integrations/angular-cli-20/package.json
- packages/solid-query-persist-client/package.json
- packages/solid-query/package.json
- examples/angular/router/package.json
- examples/vue/persister/package.json
- package.json
- .github/workflows/autofix.yml
- examples/react/default-query-function/package.json
- examples/react/shadow-dom/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (8)
examples/solid/solid-start-streaming/package.json (3)
14-14
: Bump to @solidjs/start ^1.1.7 looks good.Non-major; aligns with recent SolidStart minor fixes. No change requests.
17-17
: solid-js ^1.9.9 upgrade approved.Minor bump; expected to be safe for this example.
18-18
: vinxi ^0.5.8 upgrade approved.Minor bump; matches current SolidStart tooling.
examples/react/suspense/package.json (1)
19-22
: Version alignment looks consistent.@vitejs/plugin-react ^4.7.0 with vite ^6.3.5 is a compatible pairing; no further action needed here.
examples/angular/pagination/package.json (1)
12-15
: Peer dependencies and TS version are valid. Angular 20.2.3’s compiler-cli supports TypeScript >=5.8 <6.0 (so 5.8.3 is OK), Angular core allows RxJS ^7.4.0 (so ^7.8 is covered), and @tanstack/angular-query-experimental 5.85.7 only requires Angular >=16.0.0.examples/angular/simple/package.json (1)
12-15
: Peer/TS compatibility check.Please verify Angular 20.2.3 + TS 5.8.3 + @tanstack/angular-query-experimental ^5.85.7 + RxJS ^7.8 are mutually compatible.
Use the same script as in pagination/package.json; adjust only the package path if needed.
Also applies to: 22-25
examples/angular/devtools-panel/package.json (1)
17-18
: Peer dependencies are compatible with Angular 20 and TypeScript 5.8.3.examples/react/react-native/package.json (1)
32-33
: LGTM on dev tooling bumps.@babel/core and @expo/config minor bumps are fine and non-breaking for this example app.
fd040ec
to
62191eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
♻️ Duplicate comments (2)
examples/angular/basic/package.json (1)
22-24
: Pin Node in CI to an Angular 20–compatible version.Same repo-wide note as previously raised; ensure workflows set Node >=20.19 (or >=22.12 / >=24).
You can reuse the earlier script; optionally add:
"private": true, + "engines": { + "node": ">=20.19 || >=22.12 || >=24" + },examples/vue/basic/package.json (1)
16-16
: Same as simple example: verify peers/engines and version consistency.Matches the simple example changes; apply the same checks to avoid version drift.
Reuse the script provided in examples/vue/simple/package.json comment to confirm peer deps, Node engines, and repo-wide alignment.
Also applies to: 18-18
🧹 Nitpick comments (3)
examples/angular/basic-persister/package.json (1)
24-26
: Add Node version constraints in CI and package engine
- Workflows lack Node version pinning; add a step using
actions/setup-node@v3
withnode-version: ">=20.19 || >=22.12 || >=24"
in your CI workflow.- In examples/angular/basic-persister/package.json (lines 24–26), add:
"private": true, + "engines": { + "node": ">=20.19 || >=22.12 || >=24" + },examples/react/shadow-dom/package.json (1)
1-23
: Optional: declare Node engine here (if not enforced at root)If engines aren’t centrally enforced, add an engines field to prevent accidental installs on unsupported Node versions.
"private": true, "type": "module", + "engines": { + "node": ">=18.18.0" + },examples/svelte/simple/package.json (1)
5-9
: Optional: add a typecheck script to surface svelte-check in CI/local workflows."scripts": { "dev": "vite", "build": "vite build", - "preview": "vite preview" + "preview": "vite preview", + "typecheck": "svelte-check" },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml
(1 hunks).github/workflows/ci.yml
(1 hunks).github/workflows/pr.yml
(2 hunks)examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/2.6-basic/package.json
(1 hunks)examples/vue/2.7-basic/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(3 hunks)packages/angular-query-devtools-experimental/package.json
(1 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query-devtools/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- examples/vue/2.7-basic/package.json
- examples/solid/astro/package.json
🚧 Files skipped from review as they are similar to previous changes (75)
- examples/react/algolia/package.json
- packages/angular-query-devtools-experimental/package.json
- examples/solid/basic/package.json
- packages/query-sync-storage-persister/package.json
- examples/react/eslint-legacy/package.json
- examples/react/playground/package.json
- examples/react/suspense/package.json
- examples/react/basic-graphql-request/package.json
- examples/angular/auto-refetching/package.json
- packages/query-test-utils/package.json
- examples/vue/dependent-queries/package.json
- examples/vue/2.6-basic/package.json
- examples/react/default-query-function/package.json
- examples/solid/basic-graphql-request/package.json
- examples/svelte/auto-refetching/package.json
- packages/eslint-plugin-query/package.json
- packages/query-async-storage-persister/package.json
- packages/react-query-next-experimental/package.json
- packages/svelte-query-devtools/package.json
- integrations/react-next-15/package.json
- examples/react/star-wars/package.json
- examples/react/react-native/package.json
- integrations/vue-vite/package.json
- packages/react-query-persist-client/package.json
- examples/react/offline/package.json
- .github/workflows/ci.yml
- packages/vue-query/package.json
- examples/react/chat/package.json
- integrations/react-vite/package.json
- examples/svelte/basic/package.json
- examples/angular/optimistic-updates/package.json
- examples/solid/solid-start-streaming/package.json
- packages/solid-query-devtools/package.json
- examples/vue/persister/package.json
- packages/vue-query-devtools/package.json
- packages/query-broadcast-client-experimental/package.json
- packages/react-query-devtools/package.json
- examples/svelte/optimistic-updates/package.json
- examples/svelte/star-wars/package.json
- packages/angular-query-experimental/package.json
- examples/angular/router/package.json
- examples/react/basic/package.json
- examples/angular/pagination/package.json
- examples/angular/simple/package.json
- integrations/react-webpack-5/package.json
- examples/angular/rxjs/package.json
- examples/solid/simple/package.json
- integrations/react-webpack-4/package.json
- packages/svelte-query/package.json
- packages/solid-query/package.json
- integrations/svelte-vite/package.json
- packages/react-query/package.json
- examples/react/react-router/package.json
- packages/solid-query-persist-client/package.json
- packages/angular-query-persist-client/package.json
- packages/query-devtools/package.json
- examples/react/devtools-panel/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/react/rick-morty/package.json
- .github/workflows/pr.yml
- examples/angular/devtools-panel/package.json
- integrations/angular-cli-20/package.json
- examples/svelte/playground/package.json
- examples/solid/default-query-function/package.json
- .github/workflows/autofix.yml
- packages/svelte-query-persist-client/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/svelte/ssr/package.json
- examples/react/simple/package.json
- packages/query-core/package.json
- packages/query-persist-client-core/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/vue/nuxt3/package.json
- package.json
- integrations/solid-vite/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (7)
examples/angular/basic-persister/package.json (3)
12-15
: Angular 20.2.x bump: LGTMVersions are consistent across core Angular deps for this example.
21-21
: zone.js 0.15.1 bump: LGTMMatches Angular 20’s recommended range.
24-26
: Angular CLI/build/compiler-cli 20.2.x: LGTMTooling aligns with runtime packages.
examples/angular/basic/package.json (3)
12-15
: Angular 20.2.x bump: LGTMConsistent with other Angular example packages.
19-19
: zone.js 0.15.1 bump: LGTMNo compatibility concerns.
22-24
: Angular CLI/build/compiler-cli 20.2.x: LGTMTooling aligns with Angular 20.2.x.
examples/vue/simple/package.json (1)
16-16
: LGTM: @vitejs/[email protected] and [email protected] satisfy peerDeps (vue ^3.2.25, vite ^5.0.0||^6.0.0) and node engines (^18.0.0 || >=20.0.0), and all Vue 3 examples/integrations uniformly use 5.2.4/6.3.5.
"@vitejs/plugin-react": "^4.7.0", | ||
"typescript": "5.8.3", | ||
"vite": "^6.2.4" | ||
"vite": "^6.3.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Upgrade LGTM; verify peer/engine constraints and workspace alignment
Looks fine. Please sanity-check:
- @vitejs/plugin-react@^4.7.0 peers with vite@^6.3.5 in your lockfile.
- Node engine in CI/workspace satisfies Vite 6 (Node ≥18). Align engines across packages/examples.
- All examples use the same vite/@vitejs/plugin-react versions to avoid version drift.
Run from repo root:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "— Vite/plugin-react versions across all package.json —"
rg -nP --type=json -g '**/package.json' '"@vitejs/plugin-react"\s*:\s*"[^"]+"' -S
rg -nP --type=json -g '**/package.json' '"vite"\s*:\s*"[^"]+"' -S
echo -e "\n— Node engine declarations —"
rg -nP --type=json -g '**/package.json' '"engines"\s*:\s*{[^}]*"node"\s*:\s*"[^"]+"' -C2
echo -e "\n— Node versions referenced in repo —"
fd -HI '(.nvmrc|.node-version|package.json|pnpm-workspace.yaml|pnpm-lock.yaml)'
rg -nP -g '.github/workflows/*.yml' '(setup-node@|node-version:)' -C2
Length of output: 4641
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "— Node versions referenced in repo —"
fd -HI '.nvmrc|.node-version|pnpm-workspace.yaml|pnpm-lock.yaml'
echo -e "\n— .nvmrc contents (if present) —"
[[ -f .nvmrc ]] && cat .nvmrc
echo -e "\n— .node-version contents (if present) —"
[[ -f .node-version ]] && cat .node-version
echo -e "\n— GitHub workflows Node setup —"
rg -nP -g '.github/workflows/*.yml' '(setup-node@|node-version:)' -C2
Length of output: 750
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "— Workflow files —"
fd -HI -t f .github/workflows || echo "No workflow files found"
echo -e "\n— Node setup in workflows —"
rg -n 'uses:.*setup-node' -g '.github/workflows/**' -C2 || echo "No setup-node actions referenced"
rg -n 'node-version:' -g '.github/workflows/**' -C2 || echo "No node-version fields referenced"
Length of output: 1160
Add missing Node engine constraints and confirm CI Node version
- Verified all React examples use @vitejs/plugin-react@^4.7.0 with vite@^6.3.5 (consistent peer deps).
- .nvmrc pins Node 24.4.1 (Node ≥18) but no
"engines"
fields present—add
"engines": { "node": ">=18" }
to package.json in root, packages/, and examples/ for uniformity. - Ensure your CI workflows (e.g., GitHub Actions) are configured to use Node 24.x (≥18) per .nvmrc.
🤖 Prompt for AI Agents
In examples/react/shadow-dom/package.json around lines 19 to 21, add a top-level
"engines": { "node": ">=18" } entry (consistent with .nvmrc which pins Node
24.4.1) to explicitly state Node engine constraints; apply the same "engines"
addition to the repository root package.json and all package.json files under
packages/ and examples/ to ensure uniformity; lastly, update CI workflows (e.g.,
GitHub Actions) to use Node 24.x (or another >=18 runtime) so CI matches .nvmrc
and the declared engines.
"@tsconfig/svelte": "^5.0.5", | ||
"svelte": "^5.38.6", | ||
"svelte-check": "^4.3.1", | ||
"typescript": "5.8.3", | ||
"vite": "^6.2.4" | ||
"vite": "^6.3.5" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Safe bumps; verify toolchain compatibility (Node/Vite/Svelte/TS) and lockfile freshness.
Non-major upgrades look fine for this example. Please double-check CI/runtime constraints and repo consistency to prevent subtle breakages.
Run the following read-only checks:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "— Node engine constraints (root and workspace, if present) —"
fd -a '^package.json$' | while read -r f; do
eng=$(jq -r '(.engines.node // empty)' "$f" 2>/dev/null || true)
[[ -n "$eng" ]] && echo "$f -> engines.node: $eng"
done
echo
echo "— Actions setup-node usage (ensure Node >=18 for Vite 6) —"
rg -nC2 -g '.github/workflows/**/*.yml' -P 'uses:\s*actions/setup-node@' || true
rg -nC2 -g '.github/workflows/**/*.yml' -P 'node-version:\s*["'\'']?\d+' || true
echo
echo "— Vite/Svelte/Svelte plugin versions across repo (sanity) —"
rg -nP -g '**/package.json' '"vite"\s*:\s*".*"' | sed -E 's/.*"vite":\s*"([^"]+)".*/vite \1/'
rg -nP -g '**/package.json' '"@sveltejs/vite-plugin-svelte"\s*:\s*".*"' | sed -E 's/.*"@sveltejs\/vite-plugin-svelte":\s*"([^"]+)".*/plugin \1/'
rg -nP -g '**/package.json' '"svelte"\s*:\s*".*"' | sed -E 's/.*"svelte":\s*"([^"]+)".*/svelte \1/'
rg -nP -g '**/package.json' '"svelte-check"\s*:\s*".*"' | sed -E 's/.*"svelte-check":\s*"([^"]+)".*/svelte-check \1/'
rg -nP -g '**/package.json' '"typescript"\s*:\s*".*"' | sed -E 's/.*"typescript":\s*"([^"]+)".*/ts \1/'
echo
echo "— pnpm packageManager (lockfile compatibility) —"
fd -a '^package.json$' -x jq -r '.packageManager // empty' {} 2>/dev/null | sort -u
Length of output: 12345
🏁 Script executed:
#!/bin/bash
echo "— Plugin & tool versions in examples/svelte/simple/package.json —"
jq -r '
"svelte: " + (.dependencies.svelte // "-"),
"vite: " + (.devDependencies.vite // "-"),
"vite-plugin-svelte: " + (.devDependencies["@sveltejs/vite-plugin-svelte"] // "-"),
"svelte-check: " + (.devDependencies["svelte-check"] // "-"),
"typescript: " + (.devDependencies.typescript // "-")
' examples/svelte/simple/package.json
echo
echo "— Lockfiles in examples/svelte/simple/ —"
ls examples/svelte/simple | grep -E 'package-lock.json|yarn.lock|pnpm-lock.yaml' || echo "No lockfile found"
Length of output: 801
Commit lockfile and enforce Node ≥18. Include a lockfile (e.g. pnpm-lock.yaml
or package-lock.json
) in examples/svelte/simple/
for deterministic installs, and add
"engines": { "node": ">=18" }
to examples/svelte/simple/package.json
—or pin Node ≥18 in your CI (actions/setup-node@v3
+ node-version: 18
). DevDeps (svelte@^5.38.6
, vite@^6.3.5
, @sveltejs/vite-plugin-svelte@^5.1.1
, [email protected]
, svelte-check@^4.3.1
) are otherwise compatible.
🤖 Prompt for AI Agents
In examples/svelte/simple/package.json around lines 16 to 21, the project lacks
a lockfile for deterministic installs and does not enforce a minimum Node
version; add a lockfile (e.g., commit pnpm-lock.yaml or package-lock.json into
examples/svelte/simple/) and add an "engines": { "node": ">=18" } field to
package.json (or alternatively update CI to pin Node >=18 using
actions/setup-node@v3 with node-version: 18); ensure the listed devDependencies
remain as specified (svelte, vite, @sveltejs/vite-plugin-svelte, typescript,
svelte-check) and commit the lockfile alongside the package.json change.
e98d011
to
5f5a66e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (3)
examples/solid/astro/package.json (2)
15-15
: Add missing peer: solid-devtools for @astrojs/solid-js (verify required).If @astrojs/solid-js@^5.1.0 still peers solid-devtools, add it as a devDependency to avoid install-time warnings.
Apply if peer is required:
"dependencies": { "@astrojs/check": "^0.9.4", "@astrojs/node": "^9.1.3", "@astrojs/solid-js": "^5.1.0", "@astrojs/tailwind": "^6.0.2", "@astrojs/vercel": "^8.2.7", "@tanstack/solid-query": "^5.85.9", "@tanstack/solid-query-devtools": "^5.85.9", "astro": "^5.5.6", "solid-js": "^1.9.9", "tailwindcss": "^3.4.17", "typescript": "5.8.3" }, + "devDependencies": { + "solid-devtools": "^0.30.1" + }Run to confirm:
#!/bin/bash pnpm info @astrojs/[email protected] peerDependencies pnpm -C examples/solid/astro explain peer-requirements | rg -n "solid-devtools|solid-js" -n -C1
17-17
: Pin engines.node for Vercel runtime compatibility.Add an engines.node field matching the workspace to ensure @astrojs/vercel deploys with a supported Node version on Vercel.
Verify and choose the range used at the repo root:
#!/bin/bash jq -r '.engines? // empty' package.json jq -r '.engines? // empty' examples/solid/astro/package.jsonThen add, e.g.:
"engines": { "node": ">=18.17" }packages/eslint-plugin-query/package.json (1)
68-68
: ESLint 9 ⇒ Node ≥18.18; ensure root engines/CI enforce this.This echoes a prior note; set "engines": { "node": ">=18.18.0" } at the repo root and align CI runners accordingly.
ESLint 9 drops Node <18.18.0. (eslint.org)
🧹 Nitpick comments (1)
packages/eslint-plugin-query/package.json (1)
65-66
: RuleTester/parser v8: ensure tests use flat-config options.@typescript-eslint/rule-tester v8 mirrors ESLint 9’s flat RuleTester; tests may need languageOptions/parser adjustments.
Reference: typescript-eslint v8 announcement (flat RuleTester, ESLint 9 support). (typescripteslint.com)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml
(1 hunks).github/workflows/ci.yml
(1 hunks).github/workflows/pr.yml
(2 hunks)examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/2.6-basic/package.json
(1 hunks)examples/vue/2.7-basic/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(3 hunks)packages/angular-query-devtools-experimental/package.json
(1 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query-devtools/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- packages/vue-query/package.json
- examples/react/eslint-legacy/package.json
- examples/vue/2.6-basic/package.json
- packages/vue-query-devtools/package.json
🚧 Files skipped from review as they are similar to previous changes (77)
- examples/react/basic-graphql-request/package.json
- examples/svelte/ssr/package.json
- examples/svelte/basic/package.json
- packages/svelte-query/package.json
- packages/query-async-storage-persister/package.json
- examples/vue/simple/package.json
- examples/react/react-router/package.json
- packages/query-test-utils/package.json
- examples/svelte/playground/package.json
- .github/workflows/autofix.yml
- examples/react/devtools-panel/package.json
- examples/react/react-native/package.json
- examples/angular/rxjs/package.json
- integrations/vue-vite/package.json
- packages/react-query-next-experimental/package.json
- examples/angular/basic/package.json
- examples/react/algolia/package.json
- examples/solid/basic/package.json
- packages/solid-query-devtools/package.json
- integrations/solid-vite/package.json
- packages/solid-query-persist-client/package.json
- packages/query-sync-storage-persister/package.json
- examples/react/basic/package.json
- examples/vue/dependent-queries/package.json
- examples/vue/basic/package.json
- packages/react-query/package.json
- examples/angular/optimistic-updates/package.json
- packages/react-query-persist-client/package.json
- examples/react/shadow-dom/package.json
- examples/solid/simple/package.json
- integrations/react-webpack-5/package.json
- packages/react-query-devtools/package.json
- examples/vue/nuxt3/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/solid/solid-start-streaming/package.json
- examples/react/suspense/package.json
- packages/angular-query-persist-client/package.json
- packages/query-persist-client-core/package.json
- examples/svelte/star-wars/package.json
- packages/svelte-query-persist-client/package.json
- integrations/react-vite/package.json
- .github/workflows/ci.yml
- examples/angular/auto-refetching/package.json
- examples/react/offline/package.json
- packages/angular-query-experimental/package.json
- packages/query-core/package.json
- integrations/svelte-vite/package.json
- packages/angular-query-devtools-experimental/package.json
- examples/react/star-wars/package.json
- packages/solid-query/package.json
- integrations/react-next-15/package.json
- packages/svelte-query-devtools/package.json
- examples/react/default-query-function/package.json
- examples/svelte/optimistic-updates/package.json
- examples/solid/default-query-function/package.json
- examples/vue/persister/package.json
- examples/react/simple/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/vue/2.7-basic/package.json
- .github/workflows/pr.yml
- examples/svelte/simple/package.json
- examples/svelte/auto-refetching/package.json
- examples/react/rick-morty/package.json
- examples/react/chat/package.json
- examples/react/playground/package.json
- packages/query-devtools/package.json
- packages/query-broadcast-client-experimental/package.json
- integrations/react-webpack-4/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/angular/simple/package.json
- examples/solid/basic-graphql-request/package.json
- examples/angular/router/package.json
- integrations/angular-cli-20/package.json
- examples/angular/basic-persister/package.json
- examples/angular/pagination/package.json
- examples/angular/devtools-panel/package.json
- package.json
🔇 Additional comments (2)
examples/solid/astro/package.json (1)
21-22
: LGTM: solid-js and tailwindcss minor bumps look safe.Non-major, commonly compatible with the current Astro/Tailwind integrations.
packages/eslint-plugin-query/package.json (1)
69-69
: LGTM on npm-run-all2 patch bump.No concerns.
@@ -59,14 +59,14 @@ | |||
"!src/__tests__" | |||
], | |||
"dependencies": { | |||
"@typescript-eslint/utils": "^8.37.0" | |||
"@typescript-eslint/utils": "^8.42.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Add "engines" to declare Node >=18.18 (required by @typescript-eslint v8).
@typescript-eslint v8 packages require Node ≥18.18. Declare this here to prevent installs on unsupported Node.
Apply:
"funding": {
"type": "github",
"url": "https://github.com/sponsors/tannerlinsley"
},
+ "engines": {
+ "node": ">=18.18.0"
+ },
"scripts": {
Evidence: typescript-eslint v8 engines show Node "^18.18.0 || ^20.9.0 || >=21.1.0". (gitea.yiem.net)
🏁 Script executed:
#!/bin/bash
# Verify engines/peers of utils v8
npm view @typescript-eslint/[email protected] engines --json
npm view @typescript-eslint/[email protected] peerDependencies --json
Length of output: 710
Declare correct Node engine constraint
Add an engines
block reflecting @typescript-eslint/[email protected]’s requirement to prevent installs on unsupported Node versions.
"funding": {
"type": "github",
"url": "https://github.com/sponsors/tannerlinsley"
},
+ "engines": {
+ "node": "^18.18.0 || ^20.9.0 || >=21.1.0"
+ },
"scripts": {
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"@typescript-eslint/utils": "^8.42.0" | |
"funding": { | |
"type": "github", | |
"url": "https://github.com/sponsors/tannerlinsley" | |
}, | |
"engines": { | |
"node": "^18.18.0 || ^20.9.0 || >=21.1.0" | |
}, | |
"scripts": { |
🤖 Prompt for AI Agents
In packages/eslint-plugin-query/package.json around line 62, add an "engines"
block declaring the Node.js version constraint that matches
@typescript-eslint/[email protected] (e.g., "node": ">=14.18.0") to prevent installs
on unsupported Node versions; update the package.json by inserting the engines
field with the correct node semver and re-run your lockfile / install to ensure
package managers honor the constraint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (4)
examples/solid/astro/package.json (2)
15-15
: Add missing peer: solid-devtools for @astrojs/solid-js.Prior note still applies; add to avoid peer warnings.
Apply:
"dependencies": { "@astrojs/check": "^0.9.4", "@astrojs/node": "^9.1.3", "@astrojs/solid-js": "^5.1.0", "@astrojs/tailwind": "^6.0.2", "@astrojs/vercel": "^8.2.7", "@tanstack/solid-query": "^5.85.9", "@tanstack/solid-query-devtools": "^5.85.9", "astro": "^5.5.6", "solid-js": "^1.9.9", + "solid-devtools": "^0.30.1", "tailwindcss": "^3.4.17", "typescript": "5.8.3" }
21-22
: Pin Node engine (Astro + adapter consistency).Specify an engines.node range consistent with the workspace to avoid deploy/runtime mismatches.
Example (adjust to root policy):
{ "name": "@tanstack/query-example-solid-astro", "private": true, "type": "module", + "engines": { "node": ">=18" }, "scripts": {
Verify alignment:
#!/bin/bash jq -r '.engines?.node // "(none)"' package.json jq -r '.engines?.node // "(none)"' examples/solid/astro/package.jsonpackage.json (2)
8-8
: Align CI with pnpm 10.15.1 to avoid lockfile churnpackageManager moved to [email protected]. Ensure workflows install the same version (via pnpm/action-setup or actions/setup-pnpm) and enable corepack.
Example step:
- uses: pnpm/action-setup@v4 with: version: 10.15.1 - run: corepack enableQuick checks:
#!/bin/bash # 1) Verify pnpm is installed in workflows rg -nC2 -S -g ".github/workflows/*.{yml,yaml}" 'pnpm/action-setup|setup-pnpm|corepack' # 2) Confirm lockfile version header (pnpm-lock.yaml) rg -n '^lockfileVersion:' pnpm-lock.yaml
41-58
: Pin Node in CI to match toolchain (Typescript 5.8.x, @types/node ^22, nx 21.4.x)Add actions/setup-node with a consistent Node (e.g., 22.x) before install/build in all workflows.
Example:
- uses: actions/setup-node@v4 with: node-version: '22.x' cache: 'pnpm'Verification:
#!/bin/bash rg -nC2 -g ".github/workflows/*.{yml,yaml}" 'actions/setup-node|node-version'
🧹 Nitpick comments (4)
integrations/react-webpack-4/package.json (1)
14-17
: Keep Babel versions in lockstep across webpack-4/5 integration examples.To reduce drift in troubleshooting, mirror the same @babel/* versions in the webpack-5 example if not already.
.github/workflows/ci.yml (1)
30-30
: Optional hardening: pin to commit SHA and consider persist-credentials=false.
- Pin actions/checkout to a specific SHA for supply-chain safety.
- If not pushing with the default token in the Checkout step, set
persist-credentials: false
.Example:
-uses: actions/[email protected] +uses: actions/[email protected] # or pin to SHA with: fetch-depth: 0 + persist-credentials: falsepackage.json (2)
68-76
: Add CI matrix for TS alias packages or remove unused aliases
- CI workflows currently don’t install or test against the
typescript50
–typescript57
aliases declared in package.json (lines 68–76). Either add a matrix in your GitHub Actions (or other CI) to run tests on these versions (plus 5.8.3), or drop the unused alias entries.
53-55
: Use a stable eslint-plugin-react-hooks release or pin an exact RC version
[email protected] is a pre-release; a stable 5.2.0 is available under thelatest
tag, or if you need RC features you can bump to 6.0.0-rc.2 and pin it exactly (e.g."6.0.0-rc.2"
) to prevent unintended upgrades.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml
(1 hunks).github/workflows/ci.yml
(1 hunks).github/workflows/pr.yml
(2 hunks)examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/2.6-basic/package.json
(1 hunks)examples/vue/2.7-basic/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(3 hunks)packages/angular-query-devtools-experimental/package.json
(1 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query-devtools/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- examples/svelte/optimistic-updates/package.json
🚧 Files skipped from review as they are similar to previous changes (76)
- examples/solid/basic-graphql-request/package.json
- examples/svelte/ssr/package.json
- integrations/svelte-vite/package.json
- packages/query-core/package.json
- packages/solid-query/package.json
- examples/react/basic/package.json
- examples/svelte/star-wars/package.json
- examples/react/eslint-legacy/package.json
- examples/react/playground/package.json
- packages/query-test-utils/package.json
- examples/svelte/auto-refetching/package.json
- examples/solid/basic/package.json
- examples/solid/simple/package.json
- examples/react/default-query-function/package.json
- examples/vue/simple/package.json
- examples/react/chat/package.json
- .github/workflows/pr.yml
- packages/query-async-storage-persister/package.json
- packages/svelte-query/package.json
- packages/query-sync-storage-persister/package.json
- examples/angular/rxjs/package.json
- examples/solid/solid-start-streaming/package.json
- examples/svelte/simple/package.json
- packages/angular-query-devtools-experimental/package.json
- packages/query-persist-client-core/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/devtools-panel/package.json
- examples/svelte/playground/package.json
- integrations/angular-cli-20/package.json
- integrations/react-next-15/package.json
- packages/solid-query-devtools/package.json
- examples/vue/2.6-basic/package.json
- integrations/vue-vite/package.json
- integrations/react-vite/package.json
- examples/react/rick-morty/package.json
- packages/svelte-query-devtools/package.json
- packages/react-query-next-experimental/package.json
- examples/solid/default-query-function/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- integrations/solid-vite/package.json
- examples/angular/devtools-panel/package.json
- examples/angular/query-options-from-a-service/package.json
- packages/query-devtools/package.json
- examples/angular/basic-persister/package.json
- packages/vue-query-devtools/package.json
- packages/svelte-query-persist-client/package.json
- packages/solid-query-persist-client/package.json
- examples/react/simple/package.json
- packages/react-query-persist-client/package.json
- examples/react/star-wars/package.json
- examples/react/shadow-dom/package.json
- examples/vue/basic/package.json
- .github/workflows/autofix.yml
- examples/react/algolia/package.json
- integrations/react-webpack-5/package.json
- packages/eslint-plugin-query/package.json
- packages/angular-query-persist-client/package.json
- examples/vue/dependent-queries/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/react/suspense/package.json
- packages/react-query/package.json
- examples/react/basic-graphql-request/package.json
- examples/vue/persister/package.json
- examples/angular/pagination/package.json
- examples/react/offline/package.json
- examples/angular/router/package.json
- packages/vue-query/package.json
- examples/angular/auto-refetching/package.json
- examples/angular/optimistic-updates/package.json
- examples/react/react-router/package.json
- examples/angular/basic/package.json
- examples/react/react-native/package.json
- examples/angular/simple/package.json
- examples/vue/2.7-basic/package.json
- examples/svelte/basic/package.json
- packages/react-query-devtools/package.json
🔇 Additional comments (7)
integrations/react-webpack-4/package.json (1)
14-17
: [email protected] supports webpack 4
Peer dependencies for [email protected] specify"webpack": ">=2"
, which includes webpack 4, so no changes needed..github/workflows/ci.yml (1)
30-30
: LGTM: checkout bumped to v4.3.0.packages/angular-query-experimental/package.json (1)
71-81
: Verify peerDependencies range and CI TypeScript matrix
- peerDependencies
>=16.0.0
spans Angular 16–20; confirm your CI test matrix exercises all these versions (or optionally restrict to<21
).- ensure CI actually invokes the
test:types
scripts for TS 5.0–5.7 under Angular 20 and remains green.package.json (4)
49-51
: Vitest tooling versions look aligned@vitest/coverage-istanbul 3.2.4 and @vitest/eslint-plugin ^1.3.6 are compatible with vitest 3.2.x. No concerns.
56-56
: knip bump is fineMinor bump; low risk for CI usage. LGTM.
58-58
: nx 21.4.1 bumpLooks good. Ensure remote caching remains configured if used.
77-79
: Vite 6.3.x + Vitest 3.2.x alignmentVersions are consistent; no action needed. If any projects still rely on legacy Vite config fields, watch for deprecation warnings.
examples/vue/nuxt3/package.json
Outdated
@@ -10,6 +10,6 @@ | |||
"@tanstack/vue-query": "^5.85.9" | |||
}, | |||
"devDependencies": { | |||
"nuxt": "^3.12.4" | |||
"nuxt": "^3.18.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Nuxt 3.18 upgrade: verify Node engines and prod start behavior.
- Ensure workspace/CI Node version satisfies Nuxt 3.18’s minimum; align engines.node across repo.
- If
_start
is used in any prod context that installs only prod deps, consider movingnuxt
todependencies
or documenting that it’s dev-only.
Run:
🏁 Script executed:
#!/bin/bash
# Check declared Node engines across repo and this example
jq -r '.engines?.node // "(none)"' package.json || true
jq -r '.engines?.node // "(none)"' examples/vue/nuxt3/package.json || true
Length of output: 132
🏁 Script executed:
#!/bin/bash
set -e
cat examples/vue/nuxt3/package.json
Length of output: 344
🏁 Script executed:
#!/bin/bash
set -e
echo "Checking engines.node across all package.json files"
find . -type f -name 'package.json' -exec sh -c 'printf "%s: " "$1"; jq -r ".engines?.node // \"(none)\"" "$1"' _ {} \;
echo "Checking for .nvmrc"
[ -f .nvmrc ] && printf ".nvmrc: " && cat .nvmrc || echo "no .nvmrc"
Length of output: 5142
🌐 Web query:
What is the minimum Node.js version requirement for Nuxt 3.18.1?
💡 Result:
Minimum Node.js version: 20.x. [1][2]
Sources:
[1] Nuxt installation prerequisites (Node.js — 20.x or newer).
[2] nuxt/nuxt release notes (mentions Node v20 as minimum requirement).
Add Node engine requirement and confirm nuxt
placement
- Add
"engines": { "node": ">=20" }
to root andexamples/vue/nuxt3/package.json
to enforce Nuxt 3.18’s minimum Node.js version (nuxt.com) - Keeping
nuxt
indevDependencies
is correct—Nitro bundles all runtime code into.output
(goodpatch-tech.hatenablog.com)
🤖 Prompt for AI Agents
In examples/vue/nuxt3/package.json around line 13, add an "engines" field
specifying Node >=20 to enforce Nuxt 3.18’s minimum Node version (e.g.
"engines": { "node": ">=20" }) in both the repo root package.json and this
examples/vue/nuxt3/package.json; keep "nuxt" as a devDependency (no change
needed to move it) and ensure package.json remains valid JSON after inserting
the new field.
5f5a66e
to
f14961e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (8)
examples/react/suspense/package.json (1)
18-22
: Enforce Node >=18 (Vite 6 requirement).Add an engines constraint so CI/users don’t run under unsupported Node versions.
"type": "module", + "engines": { + "node": ">=18" + }, "scripts": {examples/react/chat/package.json (1)
17-22
: Vite + Tailwind bumps look good; verify Tailwind v4 config and CSS directives present.Ensure a tailwind.config.(js|ts) exists and some CSS includes
@tailwind base; @tailwind components; @tailwind utilities;
.#!/usr/bin/env bash set -euo pipefail echo "Tailwind configs:" fd -a -g 'tailwind.config.*' examples/react/chat || true echo echo "CSS files containing Tailwind directives:" rg -nP '@tailwind\s+(base|components|utilities)' examples/react/chat -g '**/*.{css,pcss,scss}' || trueexamples/solid/astro/package.json (2)
15-15
: Add missing peer “solid-devtools” for @astrojs/solid-js to avoid peer warnings.Apply:
"@astrojs/solid-js": "^5.1.0", + "solid-devtools": "^0.30.1",
15-23
: Pin Node engine for Astro/Solid example (Vercel/CI consistency).Add an engines field:
"dependencies": { ... "typescript": "5.8.3" } + , + "engines": { + "node": ">=18.13.0" + }examples/svelte/star-wars/package.json (1)
15-25
: SvelteKit 2.37 + Vite 6.3 require Node ≥18—declare engines.Add:
"devDependencies": { ... "vite": "^6.3.5" } + , + "engines": { + "node": ">=18.13.0" + }examples/react/react-native/package.json (1)
19-24
: Expo SDK 52 is incompatible with React Native ^0.81.x — revert RN to 0.76.x or upgrade ExpoExpo 52 targets RN 0.76.x. Keeping RN at ^0.81.1 will break native/web builds and Dev Client.
Apply this safe revert to stay within the PR’s “non‑major” scope:
- "expo": "^52.0.47", + "expo": "^52.0.47", @@ - "react-native": "^0.81.1", + "react-native": "^0.76.3",Alternatively, if you intend RN 0.81.x, bump Expo to the SDK that matches RN 0.81 and then run
npx expo install
(this would be a major update, likely out of scope for this Renovate PR).package.json (2)
8-8
: Pin pnpm 10.15.1 in CI to avoid lockfile churnpackageManager is [email protected]; ensure workflows install the same version.
Add to each workflow before install:
- uses: pnpm/action-setup@v4 with: version: '10.15.1'Search verification:
#!/bin/bash fd -H -t f .github/workflows -x rg -nC2 'pnpm/action-setup|setup-pnpm|pnpm-version|corepack'
41-59
: Pin Node in CI (recommend 22.x) for tooling compatibilityDev deps include @types/node ^22.15.3, eslint 9, vite 6, vitest 3. Pin Node 22.x in workflows to prevent runner drift.
Add early in each workflow:
- uses: actions/setup-node@v4 with: node-version: '22.x' cache: 'pnpm'Verification:
#!/bin/bash fd -H -t f .github/workflows -x rg -nC2 'setup-node|node-version'
🧹 Nitpick comments (4)
examples/solid/default-query-function/package.json (1)
13-19
: Add engines.node >=18 to match Vite 6/vite-plugin-solid runtime.Prevents accidental installs on older Node.
"type": "module", + "engines": { + "node": ">=18" + }, "scripts": {.github/workflows/autofix.yml (1)
21-21
: Consider pinning checkout to a commit SHA and (optionally) fetch full history.For supply-chain hardening, pin actions/checkout to a SHA; if autofix tasks rely on full git history (e.g., changed files), set fetch-depth: 0.
Apply:
- uses: actions/[email protected] + uses: actions/[email protected] + with: + fetch-depth: 0Tip: replace the version tag with the corresponding commit SHA.
examples/svelte/basic/package.json (1)
17-24
: Declare Node engines for SvelteKit/Vite minimums.Avoid runtime/CI drift by specifying Node ≥18.13.0.
Apply:
"devDependencies": { ... "vite": "^6.3.5" } + , + "engines": { + "node": ">=18.13.0" + }examples/angular/infinite-query-with-max-pages/package.json (1)
19-19
: Loosen zone.js to receive patch updatesUse a caret to pick up future 0.15.x patches automatically.
- "zone.js": "0.15.1" + "zone.js": "^0.15.1"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml
(1 hunks).github/workflows/ci.yml
(1 hunks).github/workflows/pr.yml
(2 hunks)examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/2.6-basic/package.json
(1 hunks)examples/vue/2.7-basic/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(3 hunks)packages/angular-query-devtools-experimental/package.json
(1 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query-devtools/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- examples/vue/2.7-basic/package.json
🚧 Files skipped from review as they are similar to previous changes (69)
- examples/svelte/auto-refetching/package.json
- examples/vue/basic/package.json
- examples/vue/nuxt3/package.json
- packages/query-core/package.json
- examples/solid/basic-graphql-request/package.json
- packages/react-query-persist-client/package.json
- examples/react/shadow-dom/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/query-devtools/package.json
- examples/svelte/playground/package.json
- packages/solid-query-devtools/package.json
- examples/react/playground/package.json
- examples/react/basic/package.json
- examples/angular/simple/package.json
- examples/vue/persister/package.json
- examples/react/algolia/package.json
- examples/solid/solid-start-streaming/package.json
- packages/query-test-utils/package.json
- examples/solid/basic/package.json
- examples/react/simple/package.json
- packages/svelte-query-persist-client/package.json
- examples/vue/2.6-basic/package.json
- integrations/react-webpack-5/package.json
- examples/angular/rxjs/package.json
- examples/svelte/optimistic-updates/package.json
- integrations/solid-vite/package.json
- packages/react-query-next-experimental/package.json
- packages/solid-query-persist-client/package.json
- examples/angular/router/package.json
- packages/query-persist-client-core/package.json
- examples/solid/simple/package.json
- packages/query-sync-storage-persister/package.json
- integrations/react-vite/package.json
- integrations/vue-vite/package.json
- packages/angular-query-persist-client/package.json
- examples/react/default-query-function/package.json
- .github/workflows/ci.yml
- packages/vue-query/package.json
- examples/react/eslint-legacy/package.json
- examples/react/offline/package.json
- examples/react/react-router/package.json
- examples/svelte/simple/package.json
- examples/angular/basic/package.json
- examples/vue/dependent-queries/package.json
- packages/vue-query-devtools/package.json
- examples/svelte/ssr/package.json
- examples/angular/query-options-from-a-service/package.json
- integrations/svelte-vite/package.json
- examples/react/devtools-panel/package.json
- examples/angular/optimistic-updates/package.json
- packages/react-query-devtools/package.json
- packages/solid-query/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/star-wars/package.json
- examples/vue/simple/package.json
- packages/svelte-query/package.json
- integrations/react-webpack-4/package.json
- packages/react-query/package.json
- .github/workflows/pr.yml
- examples/angular/devtools-panel/package.json
- examples/angular/pagination/package.json
- packages/eslint-plugin-query/package.json
- examples/angular/basic-persister/package.json
- integrations/angular-cli-20/package.json
- examples/react/rick-morty/package.json
- packages/svelte-query-devtools/package.json
- examples/react/basic-graphql-request/package.json
- examples/angular/auto-refetching/package.json
- packages/angular-query-experimental/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (4)
packages/query-async-storage-persister/package.json (1)
64-67
: npm-run-all2 CLI alias confirmed
npm-run-all2’s package.json defines a “npm-run-all” bin entry, so existing scripts invoking npm-run-all will continue to work as expected (unpkg.com)packages/angular-query-devtools-experimental/package.json (1)
57-62
: LGTM on Angular 20.2.x/dev tooling bumps.DevDeps look consistent with the repo’s Angular 20 examples; no API surface impact.
integrations/react-next-15/package.json (1)
9-9
: Temporal polyfill 0.5.1 import and API verified
Require and ESM import both succeed andTemporal.Now.instant()
is available in all use sites; no breaking changes detected.examples/angular/infinite-query-with-max-pages/package.json (1)
12-15
: Angular 20.2.x ↔ TypeScript 5.8.3 compatibility confirmed
No peer dependency errors found when installing inexamples/angular/infinite-query-with-max-pages
—no TS downgrade needed.
069a643
to
30da637
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (3)
examples/react/react-native/package.json (1)
19-29
: Expo SDK 52 is incompatible with react-native ^0.81.x — align versions.
Expo 52 targets RN 0.76.x. Either downgrade RN (and Expo-managed modules) or upgrade Expo SDK.Option A: keep Expo 52, revert RN and align native modules via Expo matrix:
- "react-native": "^0.81.1", - "react-native-gesture-handler": "^2.28.0", - "react-native-reanimated": "^3.19.1", - "react-native-safe-area-context": "^4.14.1", - "react-native-screens": "^4.15.4", - "react-native-web": "^0.21.1" + "react-native": "0.76.x", + "react-native-gesture-handler": "~2.20.2", + "react-native-reanimated": "~3.16.1", + "react-native-safe-area-context": "4.12.0", + "react-native-screens": "~4.4.0", + "react-native-web": "0.19.13"Then run: npx expo install
Option B: upgrade to Expo SDK ≥53 and keep RN 0.81.x (major upgrade; out of scope for this PR).
#!/bin/bash # Quick consistency check jq -r '.dependencies.expo, .dependencies["react-native"]' examples/react/react-native/package.jsonpackage.json (2)
8-8
: Pin pnpm 10.15.1 in CI to match packageManager.Avoid lockfile churn by ensuring runners install pnpm 10.15.1 (via actions/setup-pnpm or corepack). The prior note for 10.15.0 still applies—just bump to 10.15.1.
Run to verify/pin:
#!/bin/bash # Find workflow steps that set up pnpm and check pinned version fd -H -t f -g ".github/workflows/*.{yml,yaml}" \ -x rg -nC2 -e 'setup-pnpm|corepack enable pnpm|pnpm-version|pnpm@' echo "Recommend adding:" cat <<'YML' - uses: pnpm/action-setup@v4 with: version: '10.15.1' YML
46-46
: Pin Node in CI (recommend 22.x).Tooling here (@types/node ^22.15.3, nx 21.4.1, TS 5.8.3, Vite 6) expects modern Node. Add actions/setup-node with node-version: '22.x' across workflows.
Verify/add:
#!/bin/bash fd -H -t f -g ".github/workflows/*.{yml,yaml}" -x rg -nC2 'setup-node|node-version|matrix.*node' echo "Recommend adding:" cat <<'YML' - uses: actions/setup-node@v4 with: node-version: '22.x' cache: 'pnpm' YMLAlso applies to: 58-58, 68-68
🧹 Nitpick comments (1)
examples/angular/infinite-query-with-max-pages/package.json (1)
22-24
: Optional: align CLI/build patch to core (20.2.3) for consistency.
Helps avoid subtle mismatches when new patch fixes land.- "@angular/build": "^20.2.1", - "@angular/cli": "^20.2.1", + "@angular/build": "^20.2.3", + "@angular/cli": "^20.2.3",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml
(1 hunks).github/workflows/ci.yml
(1 hunks).github/workflows/pr.yml
(2 hunks)examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/2.6-basic/package.json
(1 hunks)examples/vue/2.7-basic/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(3 hunks)packages/angular-query-devtools-experimental/package.json
(1 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query-devtools/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- examples/react/devtools-panel/package.json
🚧 Files skipped from review as they are similar to previous changes (76)
- packages/svelte-query-devtools/package.json
- packages/query-test-utils/package.json
- packages/solid-query-devtools/package.json
- examples/svelte/ssr/package.json
- packages/angular-query-devtools-experimental/package.json
- examples/angular/router/package.json
- examples/svelte/star-wars/package.json
- integrations/svelte-vite/package.json
- packages/query-core/package.json
- .github/workflows/pr.yml
- packages/react-query-persist-client/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/offline/package.json
- examples/solid/simple/package.json
- examples/solid/solid-start-streaming/package.json
- examples/react/suspense/package.json
- packages/react-query/package.json
- examples/angular/query-options-from-a-service/package.json
- packages/query-persist-client-core/package.json
- integrations/react-webpack-5/package.json
- examples/angular/pagination/package.json
- .github/workflows/ci.yml
- examples/svelte/auto-refetching/package.json
- packages/react-query-next-experimental/package.json
- examples/react/playground/package.json
- examples/vue/2.7-basic/package.json
- integrations/react-next-15/package.json
- examples/solid/astro/package.json
- packages/query-async-storage-persister/package.json
- examples/angular/optimistic-updates/package.json
- packages/solid-query-persist-client/package.json
- examples/react/algolia/package.json
- .github/workflows/autofix.yml
- examples/angular/devtools-panel/package.json
- examples/angular/simple/package.json
- packages/vue-query-devtools/package.json
- examples/react/chat/package.json
- examples/solid/basic/package.json
- examples/react/default-query-function/package.json
- examples/svelte/simple/package.json
- examples/react/react-router/package.json
- examples/svelte/optimistic-updates/package.json
- examples/svelte/playground/package.json
- packages/solid-query/package.json
- examples/vue/persister/package.json
- packages/angular-query-experimental/package.json
- examples/angular/auto-refetching/package.json
- examples/vue/dependent-queries/package.json
- examples/react/basic-graphql-request/package.json
- examples/svelte/basic/package.json
- examples/react/eslint-legacy/package.json
- examples/vue/simple/package.json
- examples/react/basic/package.json
- examples/solid/default-query-function/package.json
- integrations/react-vite/package.json
- packages/eslint-plugin-query/package.json
- examples/react/shadow-dom/package.json
- packages/svelte-query/package.json
- integrations/vue-vite/package.json
- packages/svelte-query-persist-client/package.json
- examples/vue/nuxt3/package.json
- packages/query-sync-storage-persister/package.json
- examples/angular/basic-persister/package.json
- examples/react/simple/package.json
- examples/vue/2.6-basic/package.json
- examples/react/rick-morty/package.json
- integrations/solid-vite/package.json
- integrations/angular-cli-20/package.json
- packages/react-query-devtools/package.json
- examples/angular/rxjs/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/query-devtools/package.json
- examples/vue/basic/package.json
- examples/angular/basic/package.json
- examples/react/star-wars/package.json
- integrations/react-webpack-4/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.139Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.139Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
examples/solid/basic-graphql-request/package.json
packages/angular-query-persist-client/package.json
packages/vue-query/package.json
package.json
🔇 Additional comments (10)
examples/solid/basic-graphql-request/package.json (1)
13-15
: Peer dependency verification passed
[email protected] specifies a peer of graphql “14 – 16” and the example pins graphql to “^16.11.0”, which satisfies that range—no duplicate-graphql risk.packages/vue-query/package.json (2)
66-66
: @vue/devtools-api minor bump: OK.
No API surface change for this package; safe.
73-73
: ESLint plugin compatibility confirmed
ESLint 9.34.0 satisfies the major-9 requirement for eslint-plugin-vue ^9.33.0.packages/angular-query-persist-client/package.json (1)
60-64
: Verify CI tests against TS 5.0–5.7 with Angular 20.2.x
No TypeScript version matrix found in .github/workflows; ensure your CI runs the build/tests across TS 5.0 through 5.7 (and current) against Angular 20.2.x, or add one to validate support.examples/angular/infinite-query-with-max-pages/package.json (1)
12-20
: Core/zone bumps: looks consistent with Angular 20.2.x.
No issues spotted.examples/react/react-native/package.json (1)
32-33
: Ensure Babel preset aligns with updated Expo SDK.
Configuration is in babel.config.js (using babel-preset-expo) and there’s no custom metro.config.js; after bumping RN/Expo (SDK), manually verify that the upgraded babel-preset-expo package provides the correct compile targets for your metro build.package.json (4)
82-107
: Workspace overrides look correct for TanStack packages.Overrides include @tanstack/query-core as workspace:*, aligning with the prior learning about cross-package imports. No changes needed.
49-51
: Vitest plugin versions are consistent across repo
Only the root package.json declares Vitest and @vitest/coverage-istanbul (both at 3.2.4); no subpackage specifies either, so versions are aligned.
62-76
: TS matrix usage confirmed
The roottest:types
NX target invokes each package’stest:types:ts50–ts57
scripts, so all aliased TS versions are exercised.
53-55
: No action needed for ESLint/react-hooks compatibility. Verified that [email protected] peerDependencies include ESLint 9.0.0+ (so 9.34.0 is supported); current config extendsplugin:react-hooks/recommended
remains valid.
"vite": "^6.3.5", | ||
"vite-plugin-solid": "^2.11.8" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Ensure Node version in CI/dev meets Vite 6.x engine requirements.
Vite 6 typically requires Node 18+. Verify CI matrix and local tooling.
🏁 Script executed:
#!/bin/bash
# Verify node versions used in CI and locally
node -v || true
jq -r '.engines' package.json || true
rg -n --glob ".github/workflows/*.yml" "node-version"
Length of output: 255
Add Node engine requirement and update CI
examples/solid/basic-graphql-request/package.json: add
"engines": { "node": ">=18" }
to enforce Vite 6.x’s Node 18+ requirement; confirm any CI workflows (e.g. GitHub Actions) test on Node ≥18.
🤖 Prompt for AI Agents
In examples/solid/basic-graphql-request/package.json around lines 19 to 21, the
package.json needs an "engines" field to require Node >=18 to satisfy Vite 6.x;
add an "engines": { "node": ">=18" } entry at the top-level of package.json
(near the other metadata keys) and update any repository CI workflow files
(e.g., .github/workflows/*.yml) that test this example to include Node 18 or
higher in their matrix or use a runner setup action to set node-version: 18 or
greater.
30da637
to
2d50b74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
♻️ Duplicate comments (6)
examples/solid/solid-start-streaming/package.json (1)
14-14
: Re-check “vinxi version” script after bumps (SolidStart 1.1.7 / vinxi 0.5.8 / solid-js 1.9.9)Confirm the previous JSON import assertion issue stays resolved and that build/SSR streaming still work.
#!/bin/bash set -euo pipefail pnpm -C examples/solid/solid-start-streaming install --frozen-lockfile pnpm -C examples/solid/solid-start-streaming run version pnpm -C examples/solid/solid-start-streaming run build # Optional minimal dev smoke: # pnpm -C examples/solid/solid-start-streaming run dev & # pid=$!; sleep 8; kill $pid || trueAlso applies to: 17-19
examples/angular/query-options-from-a-service/package.json (1)
12-16
: Pin Node in CI and declare engines for Angular 20.2.xAngular 20 requires Node ^20.19.0 || ^22.12.0 || ^24.0.0. TS 5.8.3 is fine. Please:
- Add actions/setup-node with a compatible Node in CI.
- Optionally add an "engines" field here to enforce it for local installs.
Example engines snippet:
{
"engines": { "node": ">=20.19.0 <21 || >=22.12.0 <23 || >=24.0.0 <25" }
}Also applies to: 20-20, 23-25
examples/angular/rxjs/package.json (1)
12-16
: Same CI Node/engines alignment as other Angular examplesEnsure CI pins Node to a version supported by Angular 20 (and consider adding an "engines" field here too). TS 5.8.3 is within Angular’s supported range.
Also applies to: 20-20, 23-25
examples/react/react-native/package.json (1)
19-29
: Expo SDK 52 is incompatible with react-native ^0.81.x; align versionsExpo SDK 52 targets RN 0.76.x. Current RN (^0.81.1) and native modules (reanimated, gesture-handler, screens, safe-area, web) are likely mismatched and will break builds.
Choose one:
- Option A: Keep SDK 52 → set "react-native": "0.76.x" and run
npx expo install
to auto-resolve Expo-managed module versions.- Option B: Upgrade Expo to a SDK that supports RN 0.81.x, then run
npx expo install
to align all native modules.Quick safe change (Option A):
- "react-native": "^0.81.1", + "react-native": "0.76.x",Then: npx expo install
Also applies to: 32-33
package.json (2)
8-8
: Pin pnpm 10.15.1 in CI to match packageManagerWorkflows don’t appear to install pnpm explicitly. Add actions/setup-pnpm with version: 10.15.1 before install to avoid lockfile churn.
41-79
: Pin Node version in CI for consistency with @types/node 22 and nx 21Add actions/setup-node to CI (ci.yml, pr.yml, autofix.yml) with a consistent Node (e.g., 22.x or as required by framework examples) before install/build/test.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml
(1 hunks).github/workflows/ci.yml
(1 hunks).github/workflows/pr.yml
(2 hunks)examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/2.6-basic/package.json
(1 hunks)examples/vue/2.7-basic/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(3 hunks)packages/angular-query-devtools-experimental/package.json
(1 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query-devtools/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- packages/query-core/package.json
- packages/solid-query/package.json
- examples/react/simple/package.json
🚧 Files skipped from review as they are similar to previous changes (70)
- examples/angular/basic-persister/package.json
- examples/svelte/ssr/package.json
- examples/react/offline/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/vue/nuxt3/package.json
- examples/solid/astro/package.json
- .github/workflows/pr.yml
- packages/eslint-plugin-query/package.json
- packages/svelte-query-persist-client/package.json
- integrations/solid-vite/package.json
- examples/react/playground/package.json
- examples/react/suspense/package.json
- packages/vue-query-devtools/package.json
- examples/svelte/auto-refetching/package.json
- packages/vue-query/package.json
- examples/react/react-router/package.json
- .github/workflows/autofix.yml
- examples/react/devtools-panel/package.json
- integrations/svelte-vite/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/solid/default-query-function/package.json
- examples/react/basic-graphql-request/package.json
- examples/vue/basic/package.json
- examples/vue/persister/package.json
- packages/angular-query-persist-client/package.json
- packages/angular-query-devtools-experimental/package.json
- packages/query-sync-storage-persister/package.json
- packages/query-broadcast-client-experimental/package.json
- integrations/react-vite/package.json
- examples/svelte/star-wars/package.json
- examples/svelte/basic/package.json
- integrations/react-next-15/package.json
- examples/react/star-wars/package.json
- examples/react/chat/package.json
- examples/react/shadow-dom/package.json
- examples/solid/basic-graphql-request/package.json
- packages/query-devtools/package.json
- examples/vue/simple/package.json
- examples/react/algolia/package.json
- examples/angular/pagination/package.json
- packages/query-persist-client-core/package.json
- examples/solid/simple/package.json
- examples/angular/router/package.json
- packages/query-async-storage-persister/package.json
- packages/react-query-next-experimental/package.json
- examples/angular/basic/package.json
- integrations/react-webpack-4/package.json
- examples/react/rick-morty/package.json
- examples/svelte/simple/package.json
- packages/react-query-persist-client/package.json
- examples/angular/optimistic-updates/package.json
- packages/react-query/package.json
- examples/angular/devtools-panel/package.json
- packages/svelte-query/package.json
- integrations/angular-cli-20/package.json
- examples/react/default-query-function/package.json
- examples/svelte/playground/package.json
- .github/workflows/ci.yml
- packages/solid-query-devtools/package.json
- packages/angular-query-experimental/package.json
- integrations/vue-vite/package.json
- examples/vue/2.7-basic/package.json
- examples/angular/auto-refetching/package.json
- packages/svelte-query-devtools/package.json
- examples/vue/2.6-basic/package.json
- examples/vue/dependent-queries/package.json
- integrations/react-webpack-5/package.json
- examples/react/eslint-legacy/package.json
- examples/react/basic/package.json
- examples/angular/simple/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.139Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.139Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/solid-query-persist-client/package.json
examples/solid/basic/package.json
packages/react-query-devtools/package.json
package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (3)
packages/solid-query-persist-client/package.json (1)
73-77
: No @tanstack/query-core imports found; no workspace dep needed
rg search across.ts/.js
files returned no imports of@tanstack/query-core
, and type-only builds passed successfully.packages/query-test-utils/package.json (1)
38-38
: LGTM: npm-run-all2 patch bumpNo compatibility concerns expected for internal test utils.
packages/react-query-devtools/package.json (1)
86-90
: LGTM: dev tooling bumps align with repo (Vite 6, React 19)@testing-library/react ^16.3, @vitejs/plugin-react ^4.7, and npm-run-all2 ^5.0.2 look consistent with the root toolchain. No action needed.
@@ -10,11 +10,11 @@ | |||
"dependencies": { | |||
"@tanstack/solid-query": "^5.85.9", | |||
"@tanstack/solid-query-devtools": "^5.85.9", | |||
"solid-js": "^1.9.7" | |||
"solid-js": "^1.9.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Solid/Vite bumps look fine; please smoke-build the example
Vite 6 requires Node 18+. Run a quick install/build to catch any plugin or TS friction.
Consider adding an engines field ("node": ">=18") in this example to make the requirement explicit.
Also applies to: 17-18
🏁 Script executed:
#!/bin/bash
set -euo pipefail
pnpm -C examples/solid/basic install --frozen-lockfile
pnpm -C examples/solid/basic run build
# Optional dev smoke:
# pnpm -C examples/solid/basic run dev &
# pid=$!; sleep 5; kill $pid || true
Length of output: 6940
Fix build error: unresolved entry for @tanstack/solid-query
The production build is failing with:
[commonjs--resolver] Failed to resolve entry for package "@tanstack/solid-query"
Correct the main
/module
/exports
fields in packages/solid-query/package.json
or update the Vite config (e.g. resolve.alias
) to point at the proper entry before rebuilding.
Add an "engines": { "node": ">=18" }
field to examples/solid/basic/package.json
to surface the Node 18+ requirement.
🤖 Prompt for AI Agents
In examples/solid/basic/package.json around line 13, the project lacks an
"engines" field to require Node 18+, and the build fails because
@tanstack/solid-query resolves to an incorrect package entry; add "engines": {
"node": ">=18" } to this package.json, and fix the @tanstack/solid-query
resolution either by correcting packages/solid-query/package.json
main/module/exports to point to the actual build entry (CJS/ESM fields) or by
updating the Vite config (e.g., resolve.alias) in the example to map
"@tanstack/solid-query" to the correct built entry file before rebuilding.
"@sveltejs/adapter-auto": "^6.1.0", | ||
"@sveltejs/kit": "^2.37.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
SvelteKit/adapter/vite bumps: run a quick build to validate
Ensure Kit 2.37 + Svelte 5.38 + Vite 6 combo builds cleanly and SSR previews run.
If not already enforced at the repo root, consider declaring "engines": { "node": ">=18" } for SvelteKit examples.
Also applies to: 18-19, 21-21
🏁 Script executed:
#!/bin/bash
set -euo pipefail
pnpm -C examples/svelte/optimistic-updates install --frozen-lockfile
pnpm -C examples/svelte/optimistic-updates run build
pnpm -C examples/svelte/optimistic-updates run preview &
pid=$!; sleep 5; kill $pid || true
Length of output: 3962
examples/svelte/optimistic-updates build failure: unresolved “@tanstack/svelte-query”
- Vite errors out with “Failed to resolve entry for package ‘@tanstack/svelte-query’” when running
pnpm run build
in examples/svelte/optimistic-updates. Update the example’s dependency or Vite config so that the package’s exports/main fields resolve correctly and the build completes. - (Optional) Add
"engines": { "node": ">=18" }
to examples/svelte/optimistic-updates/package.json to enforce Node 18+.
🤖 Prompt for AI Agents
In examples/svelte/optimistic-updates/package.json lines 15-16, the example
fails to build because Vite cannot resolve the entry for @tanstack/svelte-query;
fix by adding or pinning a compatible @tanstack/svelte-query dependency in
package.json (e.g. add "@tanstack/svelte-query": "<compatible-version>") and/or
adjust the Vite/SvelteKit config to force bundling/SSR support for that package
(add Vite config entries such as optimizeDeps.include and ssr.noExternal for
"@tanstack/svelte-query" so its exports/main fields resolve), and optionally add
"engines": { "node": ">=18" } to package.json to enforce Node 18+.
545e576
to
9f5093a
Compare
This PR contains the following updates:
5.2.1
->5.36.0
^20.0.0
->^20.2.3
^20.0.0
->^20.2.1
^20.0.0
->^20.2.1
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^0.15.3
->^0.18.2
^5.0.7
->^5.1.0
^8.1.3
->^8.2.7
^7.26.0
->^7.28.3
^7.24.9
->^7.28.3
^7.26.0
->^7.28.3
^7.25.9
->^7.27.1
^8.17.1
->^8.19.4
^11.13.5
->^11.14.0
^11.13.5
->^11.14.1
^1.52.3
->^1.52.9
^10.0.5
->^10.0.11
^0.4.4
->^0.5.1
^0.13.4
->^0.13.11
^6.1.8
->^6.5.0
^6.1.8
->^6.4.8
^1.2.2
->^1.5.2
^2.0.26
->^2.1.3
^1.1.3
->^1.1.7
^6.0.1
->^6.1.0
^2.25.1
->^2.37.0
^2.4.0
->^2.5.0
^4.0.14
->^4.1.12
^5.76.0
->^5.85.9
^0.19.0
->^0.20.1
^17.3.7
->^17.4.0
^10.4.0
->^10.4.1
^6.6.3
->^6.8.0
^16.1.0
->^16.3.0
^2.0.0
->^2.0.1
^5.0.4
->^5.0.5
^8.37.0
->^8.42.0
^8.37.0
->^8.42.0
^8.37.0
->^8.42.0
^4.3.4
->^4.7.0
^4.3.4
->^4.7.0
^5.2.1
->^5.2.4
3.1.3
->3.2.4
^1.1.36
->^1.3.7
^6.6.3
->^6.6.4
v4.2.2
->v4.3.0
^8.3.0
->^8.4.1
^7.0.0
->^7.1.0
^9.15.0
->^9.34.0
^50.5.0
->^50.8.0
^6.0.0-rc.1
->^6.0.0-rc1
^9.27.0
->^9.33.0
^1.2.1
->^1.2.2
^52.0.11
->^52.0.47
^17.0.3
->^17.1.7
^2.0.0
->^2.2.3
^16.9.0
->^16.11.0
^7.1.2
->^7.2.0
^5.6.3
->^5.6.4
^6.2.1
->^6.2.2
^5.50.2
->^5.63.0
^2.6.6
->^2.11.1
^5.0.0
->^5.0.2
v4.1.2
->v4.3.3
^3.12.4
->^3.19.0
21.3.0
->21.4.1
10.13.1
->10.15.1
^2.5.2
->^2.6.0
^0.76.3
->^0.81.1
^2.20.2
->^2.28.0
^5.12.5
->^5.14.5
^3.16.2
->^3.19.1
^4.12.0
->^4.14.1
^4.1.0
->^4.15.4
^0.19.13
->^0.21.1
^6.25.1
->^6.30.1
^6.25.1
->^6.30.1
^8.0.0
->^8.4.0
~7.8.0
->~7.8.2
^1.9.7
->^1.9.9
^1.9.7
->^1.9.9
^0.2.3
->^0.3.0
^5.36.8
->^5.38.6
^4.3.0
->^4.3.1
^3.4.7
->^3.4.17
^3.4.7
->^3.4.17
^4.0.14
->^4.1.12
^2.3.0
->^2.8.1
^0.5.3
->^0.5.8
^6.2.4
->^6.3.5
^6.2.4
->^6.3.5
^4.5.3
->^4.5.14
4.2.3
->4.5.4
^2.11.6
->^2.11.8
^2.11.6
->^2.11.8
Summary by CodeRabbit